Skip to content

proof(actions-lock): ledger rows for the closure model; strict corpus binding - #1187

Merged
hyperpolymath merged 6 commits into
mainfrom
claude/actions-lock-closure-followups
Nov 16, 2026
Merged

hyperpolymath merged 6 commits into
mainfrom
claude/actions-lock-closure-followups

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Follow-up to #1026. Codex and CodeRabbit reviewed it about half an hour before it merged, and this PR addresses their findings.

Codex: the proof was not in the canonical ledger

verification/proof-ledger.jsonl is canonical, and the PROOF-STATUS table is rendered from it. #1026 recorded the model only in a hand-written section, so the census and the ledger tooling never saw it. This PR adds two rows:

id lane status bounds
actions-lock-closure idris2 proven none; it rests on closedIffNoDangling, danglingSound, danglingComplete, decClosed and the four corpus equations
actions-lock-closure-corpus exunit tested-only 5 corpus locks, 6 refs, lockfile versions v0.0.2 and v0.0.3

CI derives both statuses from receipts, as it does for every other row. The existing idris2 --check loop already checks this file, and the exunit lane takes its files from the ledger.

Other changes that follow:

  • The rendered table is regenerated.
  • The census quoted in README, AFFIRMATION and EXPLAINME now reads 34 proven of 55; 12 tested-only.
  • The hand-written section now names the two rows as its canonical record.

Codex: one number could stand for two refs

The ref numbering accepted two refs with the same number. Codex's example passed all 17 tests on main: it numbers both build and setup as 1 and reduces closedV00x to MkLock [1] [(1, [])]. The numbering now raises if a number or a ref appears twice, and that mutant fails 10 tests.

CodeRabbit: the fixture parser skipped lines it did not know

lock_edges/2 ignored any line it did not recognise, so a fixture written in another style could drop an edge without failing anything. Now:

  • every line must match one of the shapes the corpus uses;
  • a nested ref counts only under its record's uses: key;
  • anything else raises.

A double-quoted nested ref now fails 2 tests.

CodeRabbit's other note, on README's "Grade 3" pointer, is already fixed on main. The README now says PWG-3.

Checks

  • Corpus test run on its own: 17/17. The two mutants above fail as stated, and the first one passes against main's test.
  • scripts/proof-ledger.sh check: 55 rows valid.
  • render --check: the rendered table is current.
  • claims: all 4 quoted censuses agree with the ledger.
  • tests/proof-ledger-test.sh: 53/53.
  • scripts/check-proof-status.sh: 0 mismatches.

Formatting: I ran the Elixir 1.14 formatter, because 1.19 is not in this container. The elixir-format job runs 1.19.4 and is the authority.

No licence content is touched.


Generated by Claude Code

Review findings on #1026 after it merged:

* Codex: the model was recorded only in a hand-written PROOF-STATUS
  section, not in verification/proof-ledger.jsonl, which is canonical.
  Two rows now carry it: actions-lock-closure (idris2 lane, proven) and
  actions-lock-closure-corpus (exunit lane, tested-only, 5 locks, 6
  refs). CI derives both statuses from receipts as for any other row.
  The rendered table and the four quoted censuses are regenerated
  (34 proven of 55; 12 tested-only).
* Codex: the ref numbering accepted two refs sharing a number, so a
  transcription that merged build and setup into one record passed all
  17 tests. The numbering now raises on a reused number or a repeated
  ref; that mutant fails 10 tests.
* CodeRabbit: the fixture parser skipped any line it did not recognise,
  so a fixture in another style could drop an edge silently. Every line
  must now match a shape the corpus uses, and a nested ref counts only
  under its record's uses: key; a double-quoted nested ref fails 2 tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TbbnKqskQA5mj5gfMniPzi
Repository owner deleted a comment from coderabbitai Bot Nov 16, 2026
@hyperpolymath
hyperpolymath marked this pull request as ready for review November 16, 2026 19:30
@hyperpolymath
hyperpolymath enabled auto-merge (squash) November 16, 2026 19:30
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T21:04:43.067016Z 8c1b7ab New commits
🔒 Security Review ❌ Failed 2026-11-16T21:01:56.373929Z
We couldn’t complete this review. Comment @codex security review to try again.
8c1b7ab New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Repository owner deleted a comment from chatgpt-codex-connector Bot Nov 16, 2026
Repository owner deleted a comment from coderabbitai Bot Nov 16, 2026
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 19 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 985fcfac-54e0-4cc1-8148-8e34038677eb
Commits

Reviewing files that changed from the base of the PR and between 2f56a01 and 8c1b7ab.

Files selected for processing: 6

  • AFFIRMATION.adoc
  • EXPLAINME.adoc
  • README.adoc
  • test/rules/actions_lock_closure_corpus_test.exs
  • verification/PROOF-STATUS.adoc
  • verification/proof-ledger.jsonl
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

Copy link
Copy Markdown

This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 177a4f3b8d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread verification/proof-ledger.jsonl Resolved
Comment thread verification/proof-ledger.jsonl Resolved
…te records

Codex review on #1187:

* The proven row said each corpus row has the verdict expected.tsv gives
  it. Idris2 proves equations over the model's own constants; agreement
  with the fixtures and expected.tsv is what the tested-only row
  actions-lock-closure-corpus establishes. The proven row now claims only
  that each transcribed row evaluates to its stated dangling list and
  names the tested row for the rest.
* model_lock/2 built a map, so a record key listed twice in the model
  vanished: closedV00x with (1, [1]), (1, [2]), (2, []) passed all 17
  tests. A repeated key, or record text the pattern does not match, now
  raises, and so does a fixture that lists a record twice. That mutant
  now fails 2 tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TbbnKqskQA5mj5gfMniPzi
@chatgpt-codex-connector

Copy link
Copy Markdown

This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins.

@chatgpt-codex-connector

Copy link
Copy Markdown

This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins.

@chatgpt-codex-connector

Copy link
Copy Markdown

This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins.

@chatgpt-codex-connector

Copy link
Copy Markdown

This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit 6d8ab66 into main Nov 16, 2026
102 checks passed
@hyperpolymath
hyperpolymath deleted the claude/actions-lock-closure-followups branch November 16, 2026 21:04
hyperpolymath added a commit to hyperpolymath/mathesis that referenced this pull request Nov 17, 2026
…rkers (#105)

## Summary

This refreshes the census rows for hyperpolymath/hypatia,
metadatastician/standards and the 14 rows that have Idris2 proofs and a
non-zero `unsafe` count. The hypatia row now covers the actions.lock
closure work in hyperpolymath/hypatia#1026 and
hyperpolymath/hypatia#1187.

This PR first carried its own fix for a scanner false positive: the
Idris2 function `partial'` was counted as four `partial` annotations.
#101 landed on main meanwhile with the same fix, applied to every marker
rule. The merge `39ea12a` keeps main's scanner and drops this PR's
narrower rule and test. **The PR now changes census data only.**

## Changes

| Repository | Change |
|---|---|
| hyperpolymath/hypatia @ `29a9e4a` | own files 58 → 77, declarations
680 → 1040, unsafe 0 |
| metadatastician/standards @ `b49a33e` | own files 2 → 3, declarations
40 → 66 |
| hyperpolymath/echidna | own files 170 → 163, declarations 1969 → 1676,
from its newer commits |
| 13 other Idris2 rows with unsafe markers | move to their current
commits; counts unchanged |

The 13 rows in the last line are ambientops, deed-core,
developer-ecosystem, ephapax, poly-ssg, proven, raze-tui, reposystem,
ssg-collection, cerro-torre, gossamer, paint-type and vordr.

No unsafe count changed in the 14 refreshed Idris2 rows. Their markers
are real `partial` annotations, and the false positive affected only
hypatia.

`docs/atlas/generated/*` is regenerated with `census-atlas.mjs build`
and `render-catalogue.sh`.

## Follow-up

Standards' row still names `docs/proof-debt.adoc` as its status
document. standards#1635 renames standards' record to
`3-practice/PROOF-STATUS.adoc` and retires that ledger. Once it merges,
one more `update-rows.sh metadatastician/standards` will name the new
file.

## RSR Quality Checklist

### Required

- [x] Tests pass: `tests/census/*.sh` all pass, `bun test
tests/atlas/census-atlas.test.mjs` 13/13
- [x] Catalogue matches rows; `census-atlas.mjs check` PASS
- [x] No banned language patterns, no secrets
- [x] No source files changed

### As Applicable

- [ ] Deed and ROADMAP: not changed; project state did not change

## Open PRs this touches

This PR changes only `docs/atlas/census/rows.jsonl` and the four
generated atlas files. Of the other open PRs:

- **#98** refreshes the same hypatia row at
`6f3f16f`. This PR refreshes it at `29a9e4a`, which is later and
includes hypatia#1187. If this merges, #98 is superseded.
- **#96** (resource-algebra row) and
**#100** (ddraig-ssg row) refresh different rows.
They still edit the same files, so whichever merges second will
conflict. To resolve, rerun `scripts/census/update-rows.sh` for its row
on top of the new main, then regenerate. Do not hand-merge the generated
files.
- **#99** touches
`docs/atlas/generated/registry.adoc`, which this PR does not change.
**#102** and **#103** do not
overlap with this PR.

## Testing

Ran `update-rows.sh` on the 16 repositories on top of main at `261e6dc`.
Then ran the census tests, the catalogue diff, and the atlas build,
check and tests.

No licence content is touched.

https://claude.ai/code/session_01TbbnKqskQA5mj5gfMniPzi


---
_Generated by [Claude Code](https://claude.ai/code)_

---------

Co-authored-by: Claude <noreply@anthropic.com>
hyperpolymath added a commit to hyperpolymath/echo-types that referenced this pull request Nov 17, 2026
## Change
`HYPATIA_SHA` in `.github/workflows/hypatia-scan.yml` moves from
`7c10e5d` to `6d8ab66`, hypatia's `main` head on 2026-11-16.

The new scanner includes:
- secret-scanning findings that name the secret's file and line, and are
never hidden by path exclusions (hyperpolymath/hypatia#1184);
- the RSR 3.2.2 verdict from the capability reader
(hyperpolymath/hypatia#1188);
- the parsed workflow model for WH013 (hyperpolymath/hypatia#1192);
- the actions-lock proof ledger (hyperpolymath/hypatia#1187).

The workflow's interface to the scanner is unchanged at that commit:
`hypatia-cli.sh` is still there, and the build is still `mix
escript.build`.

## Findings at the new pin
From [run
43967735672](https://github.com/hyperpolymath/echo-types/actions/runs/43967735672)
on `29278de`:
- **Build.** The cache missed, so the scanner was built fresh from
`6d8ab66` ("Generated escript hypatia").
- **Hypatia.** Both the JSON and SARIF scans report `0 findings >=
medium (critical=0, high=0, medium=0, warn=0, low=0, info=0)`, and the
counts step reports critical 0, high 0, total 0. The gating row is 🟢
clean.
- **Alert-backed rules.** These read 0 observations. The job token can
read code-scanning and Dependabot alerts but not secret-scanning alerts,
which need an App or PAT. That limit is unchanged by this PR.

The 🔴 rows in the rendered grid come from **advisory** fleet reporters
at the pinned `gitbot-fleet` revision, not from Hypatia, and this PR
does not change them:
- **rhodibot (RSR):** 11 high. Most expect `.a2ml` descriptiles
(`ANCHOR.a2ml`, `STATE.a2ml`, `0-AI-MANIFEST.a2ml`,
`.machine_readable/descriptiles/` and others). A2ML is retired
estate-wide, so these rules are stale. They are not answered by creating
`.a2ml` files here; rhodibot's criteria need updating to deeds in
gitbot-fleet.
- **finishingbot:** 2 high and 174 medium, mostly docs that name files
which no longer exist (`All.agda`, `Smoke.agda`, `EchoVsQuotient.agda`,
…). This is a docs clean-up for its own PR.
- **glambot:** 1 medium and 136 minor (line length, heading levels).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01P4yFkxW5Heb8p2YW7ZYs9F

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants