Skip to content

ci(hypatia): pin the scanner to hypatia main 6d8ab66 - #378

Merged
hyperpolymath merged 1 commit into
mainfrom
claude/kind-clarke-aqpe7a-hypatia-pin
Nov 17, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
claude/kind-clarke-aqpe7a-hypatia-pin

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Change

HYPATIA_SHA in .github/workflows/hypatia-scan.yml moves from 7c10e5d to 6d8ab66, hypatia's main head on 2026-11-16.

The new scanner includes:

The workflow's interface to the scanner is unchanged at that commit: hypatia-cli.sh is still there, and the build is still mix escript.build.

Findings at the new pin

From run 43967735672 on 29278de:

  • Build. The cache missed, so the scanner was built fresh from 6d8ab66 ("Generated escript hypatia").
  • Hypatia. Both the JSON and SARIF scans report 0 findings >= medium (critical=0, high=0, medium=0, warn=0, low=0, info=0), and the counts step reports critical 0, high 0, total 0. The gating row is 🟢 clean.
  • Alert-backed rules. These read 0 observations. The job token can read code-scanning and Dependabot alerts but not secret-scanning alerts, which need an App or PAT. That limit is unchanged by this PR.

The 🔴 rows in the rendered grid come from advisory fleet reporters at the pinned gitbot-fleet revision, not from Hypatia, and this PR does not change them:

  • rhodibot (RSR): 11 high. Most expect .a2ml descriptiles (ANCHOR.a2ml, STATE.a2ml, 0-AI-MANIFEST.a2ml, .machine_readable/descriptiles/ and others). A2ML is retired estate-wide, so these rules are stale. They are not answered by creating .a2ml files here; rhodibot's criteria need updating to deeds in gitbot-fleet.
  • finishingbot: 2 high and 174 medium, mostly docs that name files which no longer exist (All.agda, Smoke.agda, EchoVsQuotient.agda, …). This is a docs clean-up for its own PR.
  • glambot: 1 medium and 136 minor (line length, heading levels).

🤖 Generated with Claude Code

https://claude.ai/code/session_01P4yFkxW5Heb8p2YW7ZYs9F

The Hypatia scan ran 7c10e5d. 6d8ab66 is hypatia's main head on
2026-11-16 and includes the secret-scanning location work (#1184), the
RSR 3.2.2 verdict (#1188), the WH013 workflow model (#1192) and the
actions-lock proof ledger (#1187). The workflow's interface to the
scanner is unchanged at that commit: hypatia-cli.sh is present, and the
build is mix escript.build.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01P4yFkxW5Heb8p2YW7ZYs9F
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores
    • Updated the automated scanning workflow to use a newer pinned scanner revision, keeping its build and run steps aligned with that version. There are no direct changes to the user-facing experience.

The Hypatia scan workflow updates HYPATIA_SHA to commit 6d8ab664b47a3e2abc6dedcd861e1422cd24d23f. The workflow uses this value for its cache key and scanner build and run steps.

Changes: Hypatia scan workflow

Layer / File(s) Summary
Update Hypatia pin
.github/workflows/hypatia-scan.yml
HYPATIA_SHA now identifies commit 6d8ab664b47a3e2abc6dedcd861e1422cd24d23f. The workflow uses this value for the cache key and scanner build and run steps.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to 29278

This updates the pinned version of the security scanner used in CI. No concrete risk was found, and the author says the workflow interface is unchanged. The first scan with the new version may report new findings, which the author plans to handle in this PR.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the change: the hypatia scanner is pinned to commit 6d8ab66, the main head of hypatia. The workflow change in hypatia-scan.yml matches this. The title uses the ci(hypatia) prefix and i…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description states the change: HYPATIA_SHA in hypatia-scan.yml moves from 7c10e5d to 6d8ab66. It lists the included upstream Hypatia changes and reports the scan results at the new pin, with the a…
Full details: Title check

Explanation

The title names the change: the hypatia scanner is pinned to commit 6d8ab66, the main head of hypatia. The workflow change in hypatia-scan.yml matches this. The title uses the ci(hypatia) prefix and is short and specific.

Full details: Description check

Explanation

The description states the change: HYPATIA_SHA in hypatia-scan.yml moves from 7c10e5d to 6d8ab66. It lists the included upstream Hypatia changes and reports the scan results at the new pin, with the advisory fleet reporters' findings. It matches the raw summary and PR objectives, so it is related to the changeset.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: ed27aaef-a2ce-4c81-a1c4-d1a7805b5eb2
Commits

Reviewing files that changed from the base of the PR and between 6bc52b8 and 29278de.

Files selected for processing: 1

  • .github/workflows/hypatia-scan.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 7

  • GitHub Check: CodeRabbit
  • GitHub Check: fleet / Fleet report-backs
  • GitHub Check: check
  • GitHub Check: cold-check
  • GitHub Check: Bit-narrowing exhibit
  • GitHub Check: Experimental echo-additive
  • GitHub Check: semgrep-cloud-platform/scan

@linear-code
linear-code Bot marked this pull request as ready for review November 16, 2026 22:14
@hyperpolymath
hyperpolymath merged commit cf8c6e1 into main Nov 17, 2026
41 checks passed
@hyperpolymath
hyperpolymath deleted the claude/kind-clarke-aqpe7a-hypatia-pin branch November 17, 2026 20:30
hyperpolymath added a commit to hyperpolymath/gitbot-fleet that referenced this pull request Nov 17, 2026
… …) (#687)

Follow-up to metadatastician/standards#1630 (owner ruling 2026-11-16,
made while working on hyperpolymath/rsr-template-repo#421). That PR adds
`(layout (module :gate "<row>" :at ("<path>" …)))` to `(rsr-profile …)`.

## What was wrong

J39 (standards A7) says every reader of `(rsr-profile …)` fails closed
on a key the standards module does not define. `Deed::rsr_profile`
checked only `:keyword` atoms. Any sub-clause, known or not (`(extras
…)`, now `(layout …)`), was skipped silently. A list after a scalar key,
and a repeated key, also slipped through (Codex P1, fixed in e44f179).

## Change (`bots/rhodibot/src/deed.rs`)

- Only a list after a list key (`:capabilities`, `:add`, `:remove`) is
that key's value. Any other list is a sub-clause, and it must be one of
`RSR_PROFILE_CLAUSES = ["notes", "layout"]`, each at most once. That is
the order `deed_lint.js --rsr-profile-keys` prints them in.
- Each key appears once, and its value is checked as the walk reaches
it. A list key takes a list. Every other key takes one string or symbol,
never a list, a following `:keyword`, or nothing.
- `(layout …)` is read into `ProfileClause.layout`. This reader checks:
  - `:gate` is a non-empty string, and each gate appears once;
  - `:at` is a non-empty list of strings;
  - a module carries `:gate` and `:at` only, each once.

Whether a gate names a real gate-table row, and what each path must be,
stays with standards `check-rsr-profile.sh` and `deed_lint.js
--rsr-profile`.
- `rhodibot canon` does not score module paths, so its verdicts are
unchanged.

## Evidence

- `cargo test`: 249 passed (lib 179). `cargo fmt --check` and `cargo
clippy --all-targets -- -D warnings` are clean.
- Mutation check: replacing the sub-clause refusal with `true` fails
`an_unknown_sub_clause_is_refused_not_skipped`.
- `a_list_after_a_scalar_key_is_refused` and
`a_list_key_takes_a_list_value` fail before e44f179 and pass after it.
- `rhodibot canon --path` on rsr-template-repo branch
`claude/determined-fermi-h8ojbr`, whose deed carries `(layout)`: reads
the profile, 12 declared capabilities. On standards: unchanged, 5
declared.
- CI on e44f179: all green.

## Merge order

Any order is safe. This accepts `(layout)` with or without
standards#1630, and it refuses only sub-clauses that the old and new
standards modules both refuse.

## Follow-up: moved

- **rhodibot still scores retired `.a2ml` paths** (11 high-severity
findings on hyperpolymath/echo-types#378). **Moved.** The owner made
`.a2ml` retirement a priority-1, bot-driven task through kyX (D313).
That task now belongs to the session "gitbot-fleet: fix red main + P1
auto-retire .a2ml via kyX", including reversing rhodibot's `.a2ml`
expectation. This PR stays limited to deed-clause reading. Leads handed
over:
- `bots/rhodibot/canon/rsr-criteria-v2.a2ml` still names `.a2ml` paths;
  - `src/canon/overlay.rs` has no deed form for CLADE (3.1.9);
- `src/canon/local.rs` keeps the legacy `rsr-profile.a2ml` read
fallback.

---
_Generated by [Claude
Code](https://claude.ai/code/session_01J4QvDhtp4kVy7MGgY47YB3)_

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

<!-- coderabbit-ai-generated:v1 -->

## Summary by CodeRabbit

* **New Features**
* Profiles can now include layout bindings that associate a named gate
with one or more paths.
* **Bug Fixes**
* Profile data is checked more strictly: duplicate entries, invalid
value types, unknown clauses, and incomplete or malformed layouts are
rejected.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Claude <noreply@anthropic.com>
hyperpolymath added a commit that referenced this pull request Nov 17, 2026
## Summary
Docs-only clean-up of references to files that no longer exist, prompted
by finishingbot's advisory findings (see #378). No placeholder files
were created. No `.a2ml` handling was touched. No `.agda` or workflow
files were changed. I did not edit the files that #376 or #378 touch
(`agda.yml`, `hypatia-scan.yml`, `PROOF-STATUS.adoc`,
`ECHO-CNO-BRIDGE.adoc`, `MAP.adoc`, `echo-kernel-note.adoc`,
`EchoCNO*.agda`, `Smoke.agda`, `setup-agda.sh`).

## What changed
1. **`.md` → `.adoc` successors** (about 100 references across 40 docs).
`FOUNDATION_CONTRACT`, `docs/theorem-index`, `docs/proof-obligations`,
`docs/bridge-status`, `docs/bridges/cross-repo-bridge-status`,
`docs/echo-types/{overview,taxonomy,composition,examples}`,
`core/skepticisms/*`, `CHANGELOG`, `COMPREHENSIVE_DOCUMENTATION`,
`EchoJanusBridge`. Relative links were recomputed where the doc sits in
a different directory.
2. **Moved files re-homed.** `buchholz-extended-wf` now points at
`docs/bridges/`. `wiki/Deniability.adoc` now cites
`EchoObservationalEquivalence.agda` and `EchoSecurity.agda` in
`proofs/agda/`. `docs/governance.adoc` now cites `Echo.agda`,
`characteristic/All.agda` and `EchoResidue.agda`. `gate-2-handoff` now
cites `docs/characteristic.adoc`. `paper.adoc` now cites
`gate-1-distinct-phenomenon.adoc`.
3. **Retired files reworded, not linked.** The former roadmap,
proof-roadmap and work-plan notes are described without filenames in
`roadmap.adoc`, `DOCUMENTATION_STATUS.adoc`, `overview.adoc`,
`gate1-adjacency-refresh.adoc` and `presentation-dependence.adoc`. The
`EchoVsQuotient` and `EchoVsGalois` modules never existed in this
tracked tree, so docs that cited them as "formal exhibits" now say they
are absent and not current checked evidence
(`gate-1-distinct-phenomenon`, `roadmap-gates`, `INDEX`,
`EI2_READINGS_COMPARISON`, `adjacency/{quotients,galois-connections}`).
Ordinal-lane files now say they live in ordinal-notation
(`examples.adoc`, `earn-back-plan.adoc`).

## Deliberately left
- Dated or frozen records (`CLAUDE.md`, CHANGELOG, proof-log, handoffs,
audits, `docs/retracted`, the moved ordinal copies) are left as written,
per `CLAUDE.md`.
- Intentional "does not exist" statements, such as `ModeGrade.agda` as a
forbidden naming trap and "no dedicated `adjacency/*.agda`".
- References to sibling repositories (absolute-zero, januskey, ephapax,
oikos, EchoTypes.jl, standards).
- `.scm` and `.a2ml` references in `INDEX.adoc` and
`.machine_readable/`, left for the estate-wide retirement.
- Historical audit docs `docs/integration-audit.adoc` and
`docs/next-questions.adoc`, still citing `EchoVs*`.
- Several finishingbot hits are false positives: `.k9.ncl.in` is
truncated by its scanner, and `Echo*Bridge.agda` is a glob.

## Verification
- A script scanned all `.adoc` and `.md` files for path-like references.
Every `.adoc` target introduced here resolves.
- No Agda source changed, so no typecheck was run.
- I did not re-run finishingbot itself, so its count is unconfirmed.

---
_Generated by [Claude
Code](https://claude.ai/code/session_01J4QvDi1YcoUEuuFkNCPByz)_

---------

Co-authored-by: Claude <noreply@anthropic.com>
hyperpolymath pushed a commit that referenced this pull request Nov 18, 2026
Brings in #376 (absolute-zero repinned to 8a3162a), #378 and #379
(doc reference fixes touching Smoke.agda, MAP.adoc and the bridge-status
page), which this PR also edits. Merged cleanly; re-verified below.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDizuhJtQDcxHxM2wj8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants