Repository navigation
census: refresh hypatia, standards and the Idris2 rows with unsafe markers - #105
Conversation
The Idris2 rule `^\s*partial\b` matched any line starting with an identifier spelt `partial'`, because `\b` ends a word before a prime. Re-censusing hyperpolymath/hypatia counted the four clauses of `partial'` in tests/accept/ReceiptP5MissingExact.idr as unsafe. The rule is now `^\s*partial(?![\w'])`, so it still matches the modifier on its own line or before a declaration, and no longer matches `partial'`, `partialBody` or `partial_x`. New regression test tests/census/proof_holes_partial_identifier_test.sh fails on the old rule and passes on the new one. Rows refreshed with update-rows.sh, then the atlas rebuilt: - hyperpolymath/hypatia @ 29a9e4a: 77 own files (was 58), 1040 declarations (was 680), unsafe 0. It now includes the actions.lock closure model and its ledger rows (hypatia#1026, #1187). - metadatastician/standards @ b49a33e: 3 own files (was 2), 66 declarations (was 40). Other rows were censused with the old rule and may carry the same false positive; a full re-census would correct them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TbbnKqskQA5mj5gfMniPzi
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Re-censused, with the fixed `partial` rule, every row that has Idris2 proofs and a non-zero unsafe count: ambientops, deed-core, developer-ecosystem, echidna, ephapax, poly-ssg, proven, raze-tui, reposystem, ssg-collection, cerro-torre, gossamer, paint-type, vordr. No unsafe count changed, so their markers are real `partial` modifiers and the `partial'` false positive affected only hyperpolymath/hypatia. The rows move to their current commits; the only other count that moved is echidna's own files, 170 to 163, from its newer commits. Census tests 10/10, catalogue matches rows, atlas check passes, atlas tests 13/13. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TbbnKqskQA5mj5gfMniPzi
#101 landed on main while this PR was open. It fixes the same partial' false positive, and does so for every marker rule rather than only `partial`, with its own tests. So this merge keeps main's scripts/census/proof-holes.sh and drops this branch's narrower rule and its regression test. The PR now changes census data only. The rows were re-censused on top of #101 (update-rows.sh, 16 repos): hypatia 58 -> 77 own files, 680 -> 1040 declarations, unsafe 0; standards 2 -> 3 own files, 40 -> 66 declarations; the 14 Idris2 rows with unsafe markers moved to their current commits with no unsafe count changing; echidna 170 -> 163 own files from newer commits. Census tests pass, the catalogue matches its rows, the atlas check passes and the atlas tests pass 13/13. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TbbnKqskQA5mj5gfMniPzi
main gained #96 (resource-algebra row), #99 and #104. rows.jsonl merged cleanly (different rows); index.json conflicted, so every generated file was rebuilt from the merged rows with census-atlas.mjs build and render-catalogue.sh instead of being hand-merged. The atlas check, the catalogue diff, 13 atlas tests and 9 census tests pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TbbnKqskQA5mj5gfMniPzi
|



Summary
This refreshes the census rows for hyperpolymath/hypatia, metadatastician/standards and the 14 rows that have Idris2 proofs and a non-zero
unsafecount. The hypatia row now covers the actions.lock closure work in hyperpolymath/hypatia#1026 and hyperpolymath/hypatia#1187.This PR first carried its own fix for a scanner false positive: the Idris2 function
partial'was counted as fourpartialannotations. #101 landed on main meanwhile with the same fix, applied to every marker rule. The merge39ea12akeeps main's scanner and drops this PR's narrower rule and test. The PR now changes census data only.Changes
29a9e4ab49a33eThe 13 rows in the last line are ambientops, deed-core, developer-ecosystem, ephapax, poly-ssg, proven, raze-tui, reposystem, ssg-collection, cerro-torre, gossamer, paint-type and vordr.
No unsafe count changed in the 14 refreshed Idris2 rows. Their markers are real
partialannotations, and the false positive affected only hypatia.docs/atlas/generated/*is regenerated withcensus-atlas.mjs buildandrender-catalogue.sh.Follow-up
Standards' row still names
docs/proof-debt.adocas its status document. standards#1635 renames standards' record to3-practice/PROOF-STATUS.adocand retires that ledger. Once it merges, one moreupdate-rows.sh metadatastician/standardswill name the new file.RSR Quality Checklist
Required
tests/census/*.shall pass,bun test tests/atlas/census-atlas.test.mjs13/13census-atlas.mjs checkPASSAs Applicable
Open PRs this touches
This PR changes only
docs/atlas/census/rows.jsonland the four generated atlas files. Of the other open PRs:6f3f16f. This PR refreshes it at29a9e4a, which is later and includes hypatia#1187. If this merges, chore(census): refresh the hyperpolymath/hypatia row #98 is superseded.scripts/census/update-rows.shfor its row on top of the new main, then regenerate. Do not hand-merge the generated files.docs/atlas/generated/registry.adoc, which this PR does not change. registry: close validate() over the ADR 0004 fields; THY-1 lineage labels #102 and registry: propose ADR 0005, a canonical JCS JSON route for proof receipts (prototype, unwired) #103 do not overlap with this PR.Testing
Ran
update-rows.shon the 16 repositories on top of main at261e6dc. Then ran the census tests, the catalogue diff, and the atlas build, check and tests.No licence content is touched.
https://claude.ai/code/session_01TbbnKqskQA5mj5gfMniPzi
Generated by Claude Code