Repository navigation
chore(abi): delete the seven shadow copies of packaged ABI modules (A5, 1/3) - #511
Conversation
Owner ruling on open question A5: delete the stale copies, salvage the rest.
Each file sat at the src/abi/ root outside echidnaabi.ipkg, so nothing
type-checked it. Each one was diffed against the packaged module it shadows:
BojForeign.idr = Boj/Foreign.idr (body identical)
OverlayForeign.idr = Overlay/Foreign.idr (body identical)
TentaclesForeign.idr = Tentacles/Foreign.idr (body identical)
TypeLLForeign.idr = TypeLL/Foreign.idr (body identical)
Types.idr = EchidnaABI/Types.idr (body identical)
Layout.idr = EchidnaABI/Layout.idr (body identical)
Foreign.idr older EchidnaABI/Foreign.idr: stale module name
Echidna.ABI.Foreign, no Result type, AnyPtr callback
Comments that named a shadow now name the packaged module: the four
generated/abi headers (no generator for them exists in the tree), four Zig
FFI sources, the L1 Cap'n Proto handover note and issue echidna-04. Nothing
else imported these files. src/rust/corpus/profile.rs matches only on
fixture paths under a temporary root, and reports/ are historical
snapshots, so neither changes. PROOF-STATUS R2 is updated.
CoprocessorForeign and NeSyAssistTesting follow in the next two PRs of this
stack.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
) ## Why `src/abi/CoprocessorForeign.idr` declared `module Coprocessor.Foreign`. Its module name did not match its path, so the package could not list it, and nothing type-checked it. Owner ruling on A5: put it in the package if it type-checks. ## What - `git mv` to `src/abi/Coprocessor/Foreign.idr`. The contents are unchanged. The module declares `%default total` and uses no `believe_me`, `assert_total` or `postulate`. - `echidnaabi.ipkg` lists `Coprocessor.Foreign`. **This PR's ABI type-check job is the test.** If it fails, the module comes out again; it is not forced through. - `scripts/gates/w0.sh` check 07b now looks for `Coprocessor/Foreign.idr`. At the old path the check would skip the moved file and pass vacuously. The self-test is updated: `bash scripts/gates/w0.selftest.sh` gives 68 cases, 0 failed. - The SPARK spec comments (`coprocessor_safety.ads`) and PROOF-STATUS R2 name the new path. `idris2` is not available in this session, so the type-check is left to CI. Stacked on the A5 PR 1/3 branch (`claude/new-session-th4e9w-a5-shadows`). --- _Generated by [Claude Code](https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3)_ Co-authored-by: Claude <noreply@anthropic.com>
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 17 minutes. View limit details
No actionable comments were generated in the recent review. Summary
Merge Risk:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc36ee9729
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Packaging Coprocessor.Foreign (#512) made it the checked coprocessor ABI, but its CoprocessorKind stopped at Fpga = 10. The Rust enum in src/rust/coprocessor/types.rs also declares the live Phase 2b subprocess backends PariGp, Maxima, Singular, Gap and Macaulay2 (constructed by CoprocessorFactory in coprocessor/mod.rs), with implicit discriminants 11 to 15. Add them in that order: constructors, the u8 encoding and decoding, the round-trip lemma kindEncodeDecodeId, and coprocessorHealthOf (Unhealthy, as for the other subprocess kind, Fpga). Found by Codex on #511. PROOF-STATUS R2 named "that job's first green run after the move" as the receipt, which identified no run (also Codex on #511). It now links the ABI job's green run on dc36ee9 for the eleven-kind module, and says the extended module has no receipt until that job is recorded for this commit. Idris 2 is not available in this session; the ABI job on this PR's head is the check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
….Foreign The ABI type-check job passed on ff1eef2, the commit that extended CoprocessorKind to the Rust enum. Link that run in R2 in place of the "no receipt yet" note. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
…ss (#519) ## Summary The live `Branch-Floor` ruleset on `main` requires a status check named `CI/gate`. No workflow in echidna produced that check, and `main` had none. Since 2026-11-16 19:45Z, when the ruleset last changed, no pull request has merged: #508–#511, #514 and #517 all show `blocked`, and none of them has a failing check. On 2026-11-17 the owner ruled to keep the requirement and give it a producer. This PR does that. ## Changes - `.github/workflows/rust-ci.yml`: new job `gate`, named `CI/gate`. That name is the check context the ruleset requires. - It depends on `detect`, `check`, `test`, `audit` and `coverage`. - It passes only when `Cargo.toml` was detected and all five jobs succeeded. - A skipped, cancelled or missing job fails it, so the gate cannot pass on work that did not run. - Same pattern as hypatia's `ci.yml` `CI/gate`. - No action is used, so `actions.lock` does not change. ## RSR Quality Checklist ### Required - [x] Tests pass: the gate script was run against fixtures (see Testing). - [x] Code is formatted: not applicable, YAML only. - [ ] Linter is clean: actionlint was not available in this session. The repo's Workflow Security Linter will lint the file on this PR. - [x] No banned language patterns - [x] No `unsafe` blocks without `// SAFETY:` comments: not applicable. - [x] No banned functions: not applicable. - [x] SPDX license headers present: the file keeps its existing header. - [x] No secrets, credentials, or `.env` files included ## Testing I extracted the step script with `yq` and ran it against five `needs` fixtures: | Case | Exit code | |---|---| | All five jobs succeed | 0 | | `test` failed | 1 | | `coverage` cancelled | 1 | | `has_cargo=false`, `check` skipped | 1 | | `audit` missing | 1 | **Not tested:** that GitHub reports the check under the exact context `CI/gate`. This PR's own run will show it. **Other rules may still block these PRs once `CI/gate` passes.** The live ruleset also requires: - signed commits (agent commits here are unsigned) - linear history - resolved review threads - an 80% `code_coverage` rule Those are outside this change. --- _Generated by [Claude Code](https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3)_ Co-authored-by: Claude <noreply@anthropic.com>
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
|
The schema-id step runs under `set -euo pipefail`. When either grep
matched nothing, the pipeline failed and the step exited before it
printed the ::error line, so the failure carried no message. Both greps
are now wrapped in `{ … || true; }`, so an empty result reaches the -z
check and the error is printed. Checked both ways: the real tree passes,
and a schema with no `@0x…;` line prints the error and exits 1.
PROOF-STATUS R2 cited only the 2026-11-09 receipts on a2a8643, whose
src/abi/ tree matched 2ab7574. #511, #512 and this PR have changed
src/abi/ since then. R2 now says so and cites this PR's own
Type-check Idris2 ABI definitions run.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
… in CI (#521) ## Summary This follows up on #512 (and the #511 batch). `Coprocessor.Foreign` maps each `CoprocessorKind` to a u8 tag from 0 to 15. The Rust enum in `src/rust/coprocessor/types.rs` had no discriminants. The tags therefore matched Rust only by declaration order, and reordering or inserting a Rust variant would have shifted the Rust side without any error. ## Changes - **Rust `CoprocessorKind`:** now `#[repr(u8)]` with explicit discriminants 0 to 15. Nothing in Rust casts the kind today, so behaviour does not change. - **New `scripts/ci/check-coprocessor-tags.sh`:** compares the Rust and Idris lists as `Name=tag` pairs. It fails on any difference, on a Rust variant with no explicit discriminant, or when either list is empty. - **`idris2-abi-ci.yml`:** runs that check on every event. On pushes to `main`, it also runs when `types.rs` or the script changes. - **`Coprocessor/Foreign.idr`:** - The header said "Phase 0 declares the Math kind only". It now says the module declares all sixteen kinds. - The tag doc comment no longer says Rust has no discriminants. ## RSR Quality Checklist ### Required - [x] Tests pass: the check passes on the tree and fails on both broken copies (see Testing). - [x] Code is formatted: `cargo fmt --all -- --check` passes. - [ ] Linter is clean: `cargo check --locked --lib` passes. Clippy and actionlint were not run in this session; CI runs both. - [x] No banned language patterns - [x] No `unsafe` blocks without `// SAFETY:` comments - [x] No banned functions - [x] SPDX license headers present on all new files - [x] No secrets, credentials, or `.env` files included ### As Applicable - [x] ABI/FFI changes validated: the Rust and Idris tags agree, and the check enforces it. ## Testing - `bash scripts/ci/check-coprocessor-tags.sh` on the tree prints `coprocessor tags agree: 16 kinds` and exits 0. - Copy with the Idris tag for `Gap` changed to 13: the script prints `::error … disagrees`, shows the diff `rust Gap=14` / `idris Gap=13`, and exits 1. - Copy with the Rust variant `Gap` left without a discriminant: the script prints `::error … variants without an explicit discriminant` and exits 1. --- _Generated by [Claude Code](https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3)_ --------- Co-authored-by: Claude <noreply@anthropic.com>



Why
Owner ruling on open question A5: "Delete stale, salvage rest". Seven
.idrfiles at thesrc/abi/root sat outsideechidnaabi.ipkg, so nothing type-checked them. Each one shadows a packaged module.What
I diffed each file against the module it shadows:
BojForeign.idrBoj/Foreign.idrOverlayForeign.idrOverlay/Foreign.idrTentaclesForeign.idrTentacles/Foreign.idrTypeLLForeign.idrTypeLL/Foreign.idrTypes.idrEchidnaABI/Types.idrLayout.idrEchidnaABI/Layout.idrForeign.idrEchidnaABI/Foreign.idrEchidna.ABI.Foreign, noResulttype,AnyPtrcallbackComments that named a shadow now name the packaged module. These are:
generated/abi/*.hheaders (the tree has no generator for them);Nothing imported the deleted files.
src/rust/corpus/profile.rsonly matches fixture paths under a temporary root, andreports/are historical snapshots, so neither is changed. PROOF-STATUS R2 is updated.Stack
Coprocessor.Foreignat its module path (base: this branch).NeSyAssistTesting.idrtotests/fixtures/non-proof/(base: 2).Generated by Claude Code