Skip to content

fix(ci): emit CI/gate from rust-ci so the Branch-Floor ruleset can pass - #519

Merged
hyperpolymath merged 1 commit into
mainfrom
claude/new-session-th4e9w-ci-gate
Nov 17, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
claude/new-session-th4e9w-ci-gate

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

The live Branch-Floor ruleset on main requires a status check named CI/gate. No workflow in echidna produced that check, and main had none. Since 2026-11-16 19:45Z, when the ruleset last changed, no pull request has merged: #508–#511, #514 and #517 all show blocked, and none of them has a failing check.

On 2026-11-17 the owner ruled to keep the requirement and give it a producer. This PR does that.

Changes

  • .github/workflows/rust-ci.yml: new job gate, named CI/gate. That name is the check context the ruleset requires.
    • It depends on detect, check, test, audit and coverage.
    • It passes only when Cargo.toml was detected and all five jobs succeeded.
    • A skipped, cancelled or missing job fails it, so the gate cannot pass on work that did not run.
    • Same pattern as hypatia's ci.yml CI/gate.
    • No action is used, so actions.lock does not change.

RSR Quality Checklist

Required

  • Tests pass: the gate script was run against fixtures (see Testing).
  • Code is formatted: not applicable, YAML only.
  • Linter is clean: actionlint was not available in this session. The repo's Workflow Security Linter will lint the file on this PR.
  • No banned language patterns
  • No unsafe blocks without // SAFETY: comments: not applicable.
  • No banned functions: not applicable.
  • SPDX license headers present: the file keeps its existing header.
  • No secrets, credentials, or .env files included

Testing

I extracted the step script with yq and ran it against five needs fixtures:

Case Exit code
All five jobs succeed 0
test failed 1
coverage cancelled 1
has_cargo=false, check skipped 1
audit missing 1

Not tested: that GitHub reports the check under the exact context CI/gate. This PR's own run will show it.

Other rules may still block these PRs once CI/gate passes. The live ruleset also requires:

  • signed commits (agent commits here are unsigned)
  • linear history
  • resolved review threads
  • an 80% code_coverage rule

Those are outside this change.


Generated by Claude Code

echidna's Branch-Floor ruleset requires the status check `CI/gate`, but
no workflow emitted it, so every pull request since 2026-11-16 19:45Z
has stayed blocked without a failing check to show why. The owner ruled
on 2026-11-17 to keep the requirement and give it a producer.

The new `gate` job in rust-ci.yml is named `CI/gate` and needs the five
Rust jobs. It passes only when Cargo.toml was detected and detect,
check, test, audit and coverage all succeeded; a skipped, cancelled or
missing job fails it. It uses no action, so actions.lock is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 17, 2026 00:10
Repository owner deleted a comment from coderabbitai Bot Nov 17, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T00:13:11.543997Z 2a60749 Draft marked ready
🔒 Security Review ❌ Failed 2026-11-17T00:11:03.221361Z
We couldn’t complete this review. Comment @codex security review to try again.
2a60749 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins.

Repository owner deleted a comment from coderabbitai Bot Nov 17, 2026
@hyperpolymath
hyperpolymath enabled auto-merge (squash) November 17, 2026 00:11
@hyperpolymath
hyperpolymath merged commit 17ca526 into main Nov 17, 2026
74 checks passed
@hyperpolymath
hyperpolymath deleted the claude/new-session-th4e9w-ci-gate branch November 17, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants