Skip to content

chore(abi): move NeSyAssistTesting to a non-proof fixture (A5, 3/3) - #513

Open
hyperpolymath wants to merge 6 commits into
mainfrom
claude/new-session-th4e9w-a5-nesy
Open

hyperpolymath wants to merge 6 commits into
mainfrom
claude/new-session-th4e9w-a5-nesy

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Why

src/abi/NeSyAssistTesting.idr does not parse. It also states an empirical property of the neural ranker, which a proof cannot establish. Owner ruling on A5: move it to tests/ as a non-proof fixture.

What

  • git mv to tests/fixtures/non-proof/NeSyAssistTesting.idr.
  • New tests/fixtures/non-proof/README.adoc (CC-BY-SA-4.0). It says the file is not a proof, is not type-checked, and is cited by no row.
  • After this stack, every .idr under src/abi/ is listed in echidnaabi.ipkg. I checked this with a script over git ls-files. PROOF-STATUS R2 and the wiki Home table now say so. The wiki row no longer names CapnSchemas, which fix(abi): CapnSchemas proved its claims about implicit variables; qualify, gate it in the ipkg #472 packaged.

Stacked on the A5 PR 2/3 branch.


Generated by Claude Code

claude and others added 4 commits November 16, 2026 18:16
Owner ruling on open question A5: delete the stale copies, salvage the rest.
Each file sat at the src/abi/ root outside echidnaabi.ipkg, so nothing
type-checked it. Each one was diffed against the packaged module it shadows:

  BojForeign.idr        = Boj/Foreign.idr         (body identical)
  OverlayForeign.idr    = Overlay/Foreign.idr     (body identical)
  TentaclesForeign.idr  = Tentacles/Foreign.idr   (body identical)
  TypeLLForeign.idr     = TypeLL/Foreign.idr      (body identical)
  Types.idr             = EchidnaABI/Types.idr    (body identical)
  Layout.idr            = EchidnaABI/Layout.idr   (body identical)
  Foreign.idr           older EchidnaABI/Foreign.idr: stale module name
                        Echidna.ABI.Foreign, no Result type, AnyPtr callback

Comments that named a shadow now name the packaged module: the four
generated/abi headers (no generator for them exists in the tree), four Zig
FFI sources, the L1 Cap'n Proto handover note and issue echidna-04. Nothing
else imported these files. src/rust/corpus/profile.rs matches only on
fixture paths under a temporary root, and reports/ are historical
snapshots, so neither changes. PROOF-STATUS R2 is updated.

CoprocessorForeign and NeSyAssistTesting follow in the next two PRs of this
stack.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
src/abi/CoprocessorForeign.idr declared `module Coprocessor.Foreign`, so its
module name did not match its path and the package could not list it.
Nothing type-checked it. Owner ruling on A5: salvage it into the package if
it type-checks.

- git mv to src/abi/Coprocessor/Foreign.idr (contents unchanged; the
  module declares %default total and uses no believe_me, assert_total or
  postulate).
- echidnaabi.ipkg lists Coprocessor.Foreign, so idris2-abi-ci type-checks
  it. This PR's ABI job is the type-check. If it fails, the module comes
  out again rather than being forced through.
- w0.sh check 07b now looks for Coprocessor/Foreign.idr. At the old path
  the check would skip the moved file and pass vacuously. The selftest is
  updated (68 cases, 0 failed).
- The SPARK spec comments and PROOF-STATUS R2 name the new path.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
src/abi/NeSyAssistTesting.idr does not parse. It states an empirical
property of the neural ranker, which no proof can establish. Owner ruling on
A5: move it to tests/ as a non-proof fixture.

- git mv to tests/fixtures/non-proof/, with a README that says nothing
  there is a proof or is type-checked.
- After this stack, every .idr file under src/abi/ is listed in
  echidnaabi.ipkg (checked by script). PROOF-STATUS R2 and the wiki Home
  table say so; the wiki row no longer names CapnSchemas, which #472
  packaged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
)

## Why

`src/abi/CoprocessorForeign.idr` declared `module Coprocessor.Foreign`.
Its module name did not match its path, so the package could not list
it, and nothing type-checked it. Owner ruling on A5: put it in the
package if it type-checks.

## What

- `git mv` to `src/abi/Coprocessor/Foreign.idr`. The contents are
unchanged. The module declares `%default total` and uses no
`believe_me`, `assert_total` or `postulate`.
- `echidnaabi.ipkg` lists `Coprocessor.Foreign`. **This PR's ABI
type-check job is the test.** If it fails, the module comes out again;
it is not forced through.
- `scripts/gates/w0.sh` check 07b now looks for
`Coprocessor/Foreign.idr`. At the old path the check would skip the
moved file and pass vacuously. The self-test is updated: `bash
scripts/gates/w0.selftest.sh` gives 68 cases, 0 failed.
- The SPARK spec comments (`coprocessor_safety.ads`) and PROOF-STATUS R2
name the new path.

`idris2` is not available in this session, so the type-check is left to
CI.

Stacked on the A5 PR 1/3 branch
(`claude/new-session-th4e9w-a5-shadows`).

---
_Generated by [Claude
Code](https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3)_

Co-authored-by: Claude <noreply@anthropic.com>
Base automatically changed from claude/new-session-th4e9w-a5-coprocessor to claude/new-session-th4e9w-a5-shadows November 16, 2026 19:40
@hyperpolymath
hyperpolymath marked this pull request as ready for review November 16, 2026 19:40
Repository owner deleted a comment from chatgpt-codex-connector Bot Nov 16, 2026
Repository owner deleted a comment from chatgpt-codex-connector Bot Nov 16, 2026
Repository owner deleted a comment from coderabbitai Bot Nov 16, 2026
…ession-th4e9w-a5-nesy

Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Documentation
    • Clarified that all interface definition files are included in the ABI package.
    • Updated capability and proof-status information to reflect that reference-only material sits outside the package and is not treated as a proof. The documentation also notes that this material is not checked by CI and that its empirical claim should be tested against the ranker.

The proof-status page and wiki now record that every .idr file under src/abi/ is packaged. They also record that NeSyAssistTesting.idr was moved to tests/fixtures/non-proof/. The fixture README describes its status and rationale.

Changes: Idris ABI package status

Layer / File(s) Summary
Document package status and non-proof fixture
docs/PROOF-STATUS.adoc, docs/wikis/Home.md, tests/fixtures/non-proof/README.adoc
The proof-status page and wiki state that every .idr file under src/abi/ is packaged. They record that NeSyAssistTesting.idr was moved to tests/fixtures/non-proof/ and is not a proof. The README describes the fixture’s status, rationale and testing guidance.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to f6b47

This change moves a non-proof Idris file into a test fixtures directory and updates the documentation to match. It does not alter runtime behavior, and no merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: moving NeSyAssistTesting out of the ABI package into a non-proof fixture. It also gives the A5 reference and the 3/3 stack position. The changeset matches this scope: …
Description check Passed The description covers the purpose, the file move, the new README, and the related status and wiki updates. It explains why the file moved and what the new README states. It also notes the stacking. T…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: moving NeSyAssistTesting out of the ABI package into a non-proof fixture. It also gives the A5 reference and the 3/3 stack position. The changeset matches this scope: the file move, the new README, and the PROOF-STATUS and wiki updates.

Full details: Description check

Explanation

The description covers the purpose, the file move, the new README, and the related status and wiki updates. It explains why the file moved and what the new README states. It also notes the stacking. The template's Testing section is absent, and the RSR Quality Checklist is not ticked. The author states a script check over git ls-files, but the description gives no test or formatting results.

Resolution

Consider adding a Testing section that describes the script check over git ls-files and any other verification. Consider ticking the applicable RSR Quality Checklist items, or noting which items do not apply.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 0ed9b038-f410-4bdb-baaf-5c969e5bcf85
Commits

Reviewing files that changed from the base of the PR and between 4779be0 and f6b47da.

Files selected for processing: 4

  • docs/PROOF-STATUS.adoc
  • docs/wikis/Home.md
  • tests/fixtures/non-proof/NeSyAssistTesting.idr
  • tests/fixtures/non-proof/README.adoc

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 9

  • GitHub Check: governance / Validate Hypatia Baseline
  • GitHub Check: CodeRabbit
  • GitHub Check: rust-ci / Cargo check + clippy + fmt
  • GitHub Check: rust-ci / llvm-cov line coverage
  • GitHub Check: panic-attack assail
  • GitHub Check: T1 / spass
  • GitHub Check: T1 / vampire
  • GitHub Check: T1 / eprover
  • GitHub Check: PR (address)
Additional context used

Code guidelines: 1

CLAUDE.md — auto-discovered
Path-based instructions: 1

Source excerpt: **Version + release history**: [`CHANGELOG.adoc`](CHANGELOG.adoc) (single source of truth; do not duplicate version strings elsewhere)

CodeRabbit inference engine (CLAUDE.md)

Files:

  • docs/PROOF-STATUS.adoc
  • docs/wikis/Home.md
  • tests/fixtures/non-proof/README.adoc
Learnings: 1

Learning: 2026-11-06T17:10:56.623Z

Learnt from: CR
Repo: hyperpolymath/echidna PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-11-06T17:10:56.623Z
Learning: Source excerpt:
# CLAUDE.md

## Critical Constraints

- **License**: re-ruled 2026-10-01 (D262), superseding the 2026-08 AGPL
  split — **code and the machine-readable specification surface**
  (`.machine_readable/`, package/container manifests, OCI image labels)
  MPL-2.0, matching `LICENSE` and `Cargo.toml`; **documentation**
  CC-BY-SA-4.0; **`echidna-playground/`** MPL-2.0 (Coq-Jr contributions,
  never relicensed). Never AGPL. Per-file SPDX headers are authoritative.
  When adding a file, use MPL-2.0 for code/config and CC-BY-SA-4.0 for
  prose — do not copy a header from elsewhere (a few `.a2ml` files still
  carry a stale AGPL header until their `.deed` conversion). See
  [`NOTICE`](NOTICE).

Applied to files:

  • tests/fixtures/non-proof/README.adoc

Base automatically changed from claude/new-session-th4e9w-a5-shadows to main November 17, 2026 00:33
…4e9w-a5-nesy

# Conflicts:
#	docs/PROOF-STATUS.adoc
@chatgpt-codex-connector

Copy link
Copy Markdown

This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins.

@sonarqubecloud

Copy link
Copy Markdown

hyperpolymath added a commit that referenced this pull request Nov 17, 2026
…the Agda receipt (#520)

## Summary

This follows up on #509 and #510, both already merged. An independent
review of that batch raised two gaps, and this PR closes them.

## Changes

- **`dogfood-proofs-ci.yml` (verif-idris gate from #509).** The gate
only checked that `%default total` is present. A later `partial` or
`covering` annotation, or a `%default partial|covering`, switches the
totality check off again, and the package still builds. Idris 2 defaults
to covering, and under covering `bad : Void; bad = bad` type-checks. The
gate now rejects both forms.
- **`idris2-abi-ci.yml`.** A new step applies the same ban to
`src/abi/`. It runs on every event, because it is cheap.
- **`scripts/ci/check-agda.sh` (from #510).** `git rev-parse HEAD` ran
inside `echo`'s arguments, where a failure escapes `set -e`. The receipt
would then name an empty commit and the script would still pass. The
commit is now read on its own line.

**Not in this PR:** requiring `%default total` in every `src/abi/`
module. That waits for #513, which moves the one module that lacks it
(`NeSyAssistTesting.idr`) out of `src/abi/`.

## RSR Quality Checklist

### Required

- [x] Tests pass: both new gates were run against the current tree and
against a broken copy (see Testing).
- [x] Code is formatted: no Rust changed.
- [ ] Linter is clean: actionlint was not available in this session. The
repo's Workflow Security Linter runs on this PR.
- [x] No banned language patterns
- [x] No `unsafe` blocks without `// SAFETY:` comments: not applicable.
- [x] No banned functions
- [x] SPDX license headers present: no new files.
- [x] No secrets, credentials, or `.env` files included

## Testing

- **verif-idris step:** extracted with `yq` and run on the current tree,
exit 0. On a scratch corpus where `B.idr` has a `covering` line, it
prints `::error file=…B.idr::module declares a partial or covering
definition or default` and exits 1.
- **src/abi step:** run on the current tree, exit 0. On a scratch
`src/abi/X.idr` with a `partial` line, it prints the error and exits 1.
- **`check-agda.sh`:** `bash -n` passes. The changed line was not
exercised in this session: Agda is not installed here.

---
_Generated by [Claude
Code](https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3)_

---------

Co-authored-by: Claude <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants