Repository navigation
feat(spaces): standardize portal navigation and learning hub - #4663
Open
hellofrequencylab wants to merge 8 commits into
Open
hellofrequencylab wants to merge 8 commits into
hellofrequencylab wants to merge 8 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📒 Help docs — review for this changeAdvisory only — nothing is auto-published. Vera checked 4 of 4 article(s) against the diff (docs/SUPPORT-SYSTEM.md §6). Every item in the checklist below quotes the article line it believes the diff falsifies, so you can falsify the bot. The diff contradicts these 1 article(s) — please fix before merge:
21 changed file(s). On merge, the help index re-embeds automatically. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Use Home · Community · Calendar · Program as the Frequency Space menu, with existing role-gated Manage separate. Program gathers public published Programs, Journeys and Practices at
/spaces/:slug/-/program, preserving existing custom/programpages. Root omits Community because it has no wall.Preserve independent website menus and saved visibility/plan settings. Existing Space links remain contextual Home links. Public learning reads use the request client, explicit tenant/publication filters and bounded pagination. Cards use action-capable entity pages and safe existing guest twins.
Why
The current rail mixes public destinations, section anchors, custom links and management. A fixed menu makes the Space easier to understand without removing functions or overwriting customer configuration.
Risk
Shared Space navigation and one new public route. No SQL, migration, provider setting, role, entitlement or stored customer data changes. Full CI, READY preview and desktop/mobile role acceptance remain outstanding;
LIVE-SPACE-NAVstays open. Root owns serialized merging; auto-merge stays off.Daniel approved the exact seven-file test patch, SHA256
03b8aa34305ae4bc6ce60489158cf74577683e1dbf685ac9dd0662fdb9bb8868. Existing feature authorization, entitlement, presence and negative controls remain against the contextual/editor catalog. Added fixed-menu, safe reader, pagination, saved-link and guest-twin checks. No baseline, threshold or probe was relaxed.How to verify
93c68083049621c341498a67f68135113bba3697; no conflicts; 21-file PR diff including the approved ledger-probe correction.80304e7bdf88027f86c95d18ba7d486cbfe4309d: 134 tests pass across 10 files; changed source/test lint and menu/authz/canon/backlog checks pass.80304e7bdf88027f86c95d18ba7d486cbfe4309d. The later approved probe correction changes no menu source/test code. Exact-final-head whole-repo CI remains required.067ecfbc169e7d5fed8d38c98a35bc7a28d48251is pushed withfull-ci; exact-head CI and preview checks must finish before release.78ccf6db5b4a5d9b6f7756da6cff41ed20da12c9a4b7add7f3b6a57394414735. It changes only the probe's staleSpace page onlyliteral to the actualSpace Home links onlylabel. The actual merged command passes; all ten saved-menu/plan/visibility/dropdown/mount/logo negative controls still fail when their guarded source is removed. Static backlog, one-list and diff checks pass; no UI was changed to satisfy the stale assertion.Coordination: #4306 (comment).