Skip to content

feat(spaces): standardize portal navigation and learning hub - #4663

Open
hellofrequencylab wants to merge 8 commits into
mainfrom
codex/space-menu-20261104
Open

hellofrequencylab wants to merge 8 commits into
mainfrom
codex/space-menu-20261104

Conversation

@hellofrequencylab

@hellofrequencylab hellofrequencylab commented Nov 4, 2026 •

Copy link
Copy Markdown
Owner

What

Use Home · Community · Calendar · Program as the Frequency Space menu, with existing role-gated Manage separate. Program gathers public published Programs, Journeys and Practices at /spaces/:slug/-/program, preserving existing custom /program pages. Root omits Community because it has no wall.

Preserve independent website menus and saved visibility/plan settings. Existing Space links remain contextual Home links. Public learning reads use the request client, explicit tenant/publication filters and bounded pagination. Cards use action-capable entity pages and safe existing guest twins.

Why

The current rail mixes public destinations, section anchors, custom links and management. A fixed menu makes the Space easier to understand without removing functions or overwriting customer configuration.

Risk

Shared Space navigation and one new public route. No SQL, migration, provider setting, role, entitlement or stored customer data changes. Full CI, READY preview and desktop/mobile role acceptance remain outstanding; LIVE-SPACE-NAV stays open. Root owns serialized merging; auto-merge stays off.

Daniel approved the exact seven-file test patch, SHA256 03b8aa34305ae4bc6ce60489158cf74577683e1dbf685ac9dd0662fdb9bb8868. Existing feature authorization, entitlement, presence and negative controls remain against the contextual/editor catalog. Added fixed-menu, safe reader, pagination, saved-link and guest-twin checks. No baseline, threshold or probe was relaxed.

How to verify

  • Normally merged main 93c68083049621c341498a67f68135113bba3697; no conflicts; 21-file PR diff including the approved ledger-probe correction.
  • Integrated head 80304e7bdf88027f86c95d18ba7d486cbfe4309d: 134 tests pass across 10 files; changed source/test lint and menu/authz/canon/backlog checks pass.
  • Scoped TypeScript passed (316.1s) for all 11 changed menu source roots, all seven approved test roots and dependencies at integration head 80304e7bdf88027f86c95d18ba7d486cbfe4309d. The later approved probe correction changes no menu source/test code. Exact-final-head whole-repo CI remains required.
  • Current head 067ecfbc169e7d5fed8d38c98a35bc7a28d48251 is pushed with full-ci; exact-head CI and preview checks must finish before release.
  • Daniel additionally approved LIVE-891 patch SHA256 78ccf6db5b4a5d9b6f7756da6cff41ed20da12c9a4b7add7f3b6a57394414735. It changes only the probe's stale Space page only literal to the actual Space Home links only label. The actual merged command passes; all ten saved-menu/plan/visibility/dropdown/mount/logo negative controls still fail when their guarded source is removed. Static backlog, one-list and diff checks pass; no UI was changed to satisfy the stale assertion.
  • Check READY preview; desktop/mobile keyboard, one active destination, separate Manage per role, disabled functions, empty/error/paged learning, private/unlisted/draft refusal, custom Program pages and website-only links. Verify member enrollment/adoption and safe guest destinations before production release.

Coordination: #4306 (comment).

@vercel

vercel Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
frequency-web Ready Ready Preview Nov 4, 2026 7:30pm UTC

Request Review

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

📒 Help docs — review for this change

Advisory only — nothing is auto-published. Vera checked 4 of 4 article(s) against the diff (docs/SUPPORT-SYSTEM.md §6). Every item in the checklist below quotes the article line it believes the diff falsifies, so you can falsify the bot.

The diff contradicts these 1 article(s) — please fix before merge:

  • content/help/spaces/menu-and-logo.md — The diff shows Space page and website now have separate menus. The article claims they share one menu that syncs between platforms, but the change indicates the website keeps its own independent menu.
    • article says: "Your Space page and your website share one menu. Change it in either place and the other follows, so you never keep two lists in step by hand."
    • diff says: components/spaces/site-menu-editor.tsx → // and in the website editor's header settings, editing the website menu and shared header logo.

21 changed file(s). On merge, the help index re-embeds automatically.

This branch was successfully deployed

1 active deployment
Preview — a579dbd4 Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants