Repository navigation
fix(ci): preserve visual reports across tiers - #4672
Open
hellofrequencylab wants to merge 3 commits into
Open
hellofrequencylab wants to merge 3 commits into
hellofrequencylab wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final visual upload previously kept only the advisory tier because each invocation cleared the preceding tier's result and HTML directories. Give public, member and advisory runs independent directories so all three visual report sets survive.
Daniel approved exact workflow patch SHA256
05b29b302606bea428c260a5e22b617a28c4dbd95767ee04d72eaaea9aa0c7f4. The workflow matches that reviewed candidate byte for byte: six YAML leaves. Upload roots, selectors, secrets, timeouts, thresholds, baselines and blocking/advisory semantics are unchanged. The accompanying OPEN finding is assigned to W7.Validation:
The original visual and Lighthouse failures remain evidence; this PR does not claim an application visual or performance pass. The root HTML report contains the production-contract suite: that earlier invocation still overwrites smoke HTML. This inherited smoke-retention gap keeps the finding OPEN; separate two-leaf follow-up cbf1ca61 is external and unapplied pending exact approval.
No application code, baselines, SQL or operator procedures changed. #4663/#4669 and their original runs remain untouched.