fix(cmd): lowercase logs, fix stale comment - #1041
Merged
Merged
Conversation
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
skevetter
marked this pull request as ready for review
August 18, 2026 04:08
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewed
cmd/pro/workspace/for small command-structure and convention improvements.Issue found
In the workspace sleep/wakeup commands, a stale comment and uppercase log strings violated the repo's documented conventions:
wakeup.goreused the sleep command's// wait for sleepingcomment, which is incorrect for the wakeup path (a copy-paste fromsleep.go).wakeup.goandsleep.golog messages started with an uppercase letter, violating the lowercase-log convention fromAGENTS.md("Logs: Log messages and logging strings are lowercase.").This is a readability/convention fix — no behavioral change to command logic, flags, or data flow.
Change
cmd/pro/workspace/wakeup.go:// wait for sleeping→// wait for the workspace to wake up(corrects the stale, copied comment)"Workspace %s is not sleeping"→"workspace %s is not sleeping"(lowercase log)"Wait until workspace wakes up"→"wait until workspace wakes up"(lowercase log)cmd/pro/workspace/sleep.go:// wait for sleeping→// wait for the workspace to sleep(consistent wording)"Wait until workspace is sleeping"→"wait until workspace is sleeping"(lowercase log)Verification
task cli:format— cleantask cli:lint:ci— 0 issuestask cli:test— passes (only known pre-existingpkg/gitTestRepoClone*failures, which fail onorigin/mainindependently of this change; this PR does not touchpkg/git)go build ./cmd/pro/workspace/— builds successfullyCommit
4762f2dis app-signed (verified=true).This PR was created by an AI agent as part of an automated daily CLI review job.