Skip to content

fix(cmd): lowercase logs, fix stale comment - #1041

Merged
skevetter merged 2 commits into
mainfrom
cmd-reviewer/pro-workspace-stale-log
Aug 18, 2026
Merged

fix(cmd): lowercase logs, fix stale comment#1041
skevetter merged 2 commits into
mainfrom
cmd-reviewer/pro-workspace-stale-log

Conversation

@devsy-app

@devsy-app devsy-app Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Reviewed cmd/pro/workspace/ for small command-structure and convention improvements.

Issue found

In the workspace sleep/wakeup commands, a stale comment and uppercase log strings violated the repo's documented conventions:

  • wakeup.go reused the sleep command's // wait for sleeping comment, which is incorrect for the wakeup path (a copy-paste from sleep.go).
  • wakeup.go and sleep.go log messages started with an uppercase letter, violating the lowercase-log convention from AGENTS.md ("Logs: Log messages and logging strings are lowercase.").

This is a readability/convention fix — no behavioral change to command logic, flags, or data flow.

Change

  • cmd/pro/workspace/wakeup.go:
    • // wait for sleeping// wait for the workspace to wake up (corrects the stale, copied comment)
    • "Workspace %s is not sleeping""workspace %s is not sleeping" (lowercase log)
    • "Wait until workspace wakes up""wait until workspace wakes up" (lowercase log)
  • cmd/pro/workspace/sleep.go:
    • // wait for sleeping// wait for the workspace to sleep (consistent wording)
    • "Wait until workspace is sleeping""wait until workspace is sleeping" (lowercase log)

Verification

  • task cli:format — clean
  • task cli:lint:ci0 issues
  • task cli:test — passes (only known pre-existing pkg/git TestRepoClone* failures, which fail on origin/main independently of this change; this PR does not touch pkg/git)
  • go build ./cmd/pro/workspace/ — builds successfully

Commit 4762f2d is app-signed (verified=true).

This PR was created by an AI agent as part of an automated daily CLI review job.

@netlify

netlify Bot commented Aug 14, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 21e1772
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a83dae0e7b33600093f2444

@netlify

netlify Bot commented Aug 14, 2026

Copy link
Copy Markdown

Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 21e1772
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6a83dae07ee54f000830025c

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@skevetter
skevetter marked this pull request as ready for review August 18, 2026 04:08
@mergify

mergify Bot commented Aug 18, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@skevetter
skevetter merged commit 8af2546 into main Aug 18, 2026
134 of 137 checks passed
@skevetter
skevetter deleted the cmd-reviewer/pro-workspace-stale-log branch August 18, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant