fix(cmd): lowercase pro cluster logs - #1055
Open
devsy-app[bot] wants to merge 2 commits into
Open
Conversation
lowercase three log strings in cmd/pro/cluster/add.go to follow the repo's lowercase-logs convention (installing agent, running helm command, waiting for cluster init). no behavioral change.
✅ Deploy Preview for devsydev canceled.
|
✅ Deploy Preview for images-devsy-sh canceled.
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmd subdirectory reviewed
cmd/pro/cluster/(specificallycmd/pro/cluster/add.go)Issue found
The Devsy repo convention is lowercase log strings (documented in
AGENTS.md: "Log messages and logging strings are lowercase."). Three log statements incmd/pro/cluster/add.goviolated this convention, starting with an uppercase letter:log.Info("Installing agent")log.Debugf("Running helm command: %v", helmCmd.Args)log.Info("Waiting for the cluster to be initialized")These are runtime status messages emitted during
devsy pro cluster add, so they appear in user-facing logs alongside the rest of the (already lowercase) log output, causing inconsistent capitalization.Minimal change
Lowercased the three log strings only — no behavioral changes:
log.Info("installing agent")log.Debugf("running helm command: %v", helmCmd.Args)log.Info("waiting for the cluster to be initialized")A duplicate-PR guard was run: existing open PR #1041 (
cmd-reviewer/pro-workspace-stale-log) only touchescmd/pro/workspace/{sleep,wakeup}.go, so thiscmd/pro/clusterchange does not overlap.Verification performed
task cli:format— clean (gofmt/gci/gofumpt via golangci-lint fmt).task cli:lint:ci— 0 issues (new-from-patch against origin/main).task cli:test— passes except the known pre-existing failures:pkg/git(TestRepoClone*) — stale assertion on origin/main, not caused by this change (confirmed by stashing the change and reproducing the failure on clean main).e2e(TestRunE2ETests) — also pre-existing on origin/main, reproduced with the change stashed. This change touches only log-string literals incmd/pro/cluster/add.goand cannot affect either suite.grepconfirmed), so no test assertions break.This PR was created by an AI agent as part of an automated daily CLI review job.