Skip to content

fix(cmd): lowercase pro cluster logs - #1055

Open
devsy-app[bot] wants to merge 2 commits into
mainfrom
cmd-reviewer/pro-cluster-lowercase-logs
Open

fix(cmd): lowercase pro cluster logs#1055
devsy-app[bot] wants to merge 2 commits into
mainfrom
cmd-reviewer/pro-cluster-lowercase-logs

Conversation

@devsy-app

@devsy-app devsy-app Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

cmd subdirectory reviewed

cmd/pro/cluster/ (specifically cmd/pro/cluster/add.go)

Issue found

The Devsy repo convention is lowercase log strings (documented in AGENTS.md: "Log messages and logging strings are lowercase."). Three log statements in cmd/pro/cluster/add.go violated this convention, starting with an uppercase letter:

  • log.Info("Installing agent")
  • log.Debugf("Running helm command: %v", helmCmd.Args)
  • log.Info("Waiting for the cluster to be initialized")

These are runtime status messages emitted during devsy pro cluster add, so they appear in user-facing logs alongside the rest of the (already lowercase) log output, causing inconsistent capitalization.

Minimal change

Lowercased the three log strings only — no behavioral changes:

  • log.Info("installing agent")
  • log.Debugf("running helm command: %v", helmCmd.Args)
  • log.Info("waiting for the cluster to be initialized")

A duplicate-PR guard was run: existing open PR #1041 (cmd-reviewer/pro-workspace-stale-log) only touches cmd/pro/workspace/{sleep,wakeup}.go, so this cmd/pro/cluster change does not overlap.

Verification performed

  • task cli:format — clean (gofmt/gci/gofumpt via golangci-lint fmt).
  • task cli:lint:ci0 issues (new-from-patch against origin/main).
  • task cli:test — passes except the known pre-existing failures:
    • pkg/git (TestRepoClone*) — stale assertion on origin/main, not caused by this change (confirmed by stashing the change and reproducing the failure on clean main).
    • e2e (TestRunE2ETests) — also pre-existing on origin/main, reproduced with the change stashed. This change touches only log-string literals in cmd/pro/cluster/add.go and cannot affect either suite.
  • No tests reference the changed log strings (grep confirmed), so no test assertions break.

This PR was created by an AI agent as part of an automated daily CLI review job.

lowercase three log strings in cmd/pro/cluster/add.go to follow the repo's lowercase-logs convention (installing agent, running helm command, waiting for cluster init). no behavioral change.
@netlify

netlify Bot commented Aug 15, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit ee3de9d
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a82a16892046d000891b319

@netlify

netlify Bot commented Aug 15, 2026

Copy link
Copy Markdown

Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit ee3de9d
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6a82a168702834000897b660

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant