Skip to content

fix(cmd): lowercase logs, fix stale comment #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 2 commits into from
Aug 18, 2026
+5 −5
Merged

fix(cmd): lowercase logs, fix stale comment #1041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4762f2d
fix(cmd): lowercase logs, fix stale comment
devsy-app[bot] Aug 14, 2026
21e1772
Merge branch 'main' into cmd-reviewer/pro-workspace-stale-log
skevetter Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/pro/workspace/sleep.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ func (cmd *SleepCmd) sleep(
return err
}

// wait for sleeping
log.Info("Wait until workspace is sleeping")
// wait for the workspace to sleep
log.Info("wait until workspace is sleeping")
err = waitForWorkspacePhase(ctx, waitForWorkspacePhaseParams{
managementClient: managementClient,
projectName: cmd.Project,
Expand Down
6 changes: 3 additions & 3 deletions cmd/pro/workspace/wakeup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func (cmd *WakeupCmd) wakeup(
workspaceInstance *managementv1.DevsyWorkspaceInstance,
) error {
if workspaceInstance.Status.Phase != storagev1.InstanceSleeping {
log.Infof("Workspace %s is not sleeping", workspaceInstance.Name)
log.Infof("workspace %s is not sleeping", workspaceInstance.Name)
return nil
}

Expand All @@ -101,8 +101,8 @@ func (cmd *WakeupCmd) wakeup(
return err
}

// wait for sleeping
log.Info("Wait until workspace wakes up")
// wait for the workspace to wake up
log.Info("wait until workspace wakes up")
err = waitForWorkspacePhase(ctx, waitForWorkspacePhaseParams{
managementClient: managementClient,
projectName: cmd.Project,
Expand Down
Loading