Repository navigation
Conversation
The fixture in integration/templates/expo-native reads launch inputs whose names start with verify, and always renders one home with a button for each screen a test needs. modules/verify-launch-config reads the inputs on iOS and Android. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…an them The tests in integration/tests/expo-native drove the home that the fixture no longer has. The integration/expo-native package, later in this stack, has a test for each of their flows. The Expo workflow keeps its native build jobs, now named Native Build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 8ef9eb4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-native-components
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
This was referenced Oct 14, 2026
A pull request now builds the expo-native fixture on SDK 57 only, for iOS and Android. A nightly run on main at 07:00 UTC, which forks skip, and a manual run build SDK 54, 55, and 57. The Gradle cache now uses its default, written only from main, because the nightly run seeds it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…sts" This reverts commit 086447e. Expo test timing stays as it was for now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the first of four pull requests that replace the eleven of stack #10100, #10052 to #10230. It holds #10052 and the part of #10090 that changes the fixture. Every file is in its final state, as at the head of #10230, so no later pull request in this stack changes it again. #10236 sits on this one.
The
expo-nativefixture inintegration/templates/expo-nativenow always renders one home,verify/VerifyHost.tsx, and reads launch inputs whose names start withverify. With them, a test starts signed in or from clean storage without tapping through a sign-in first. The home shows who is signed in, asuseAuth,useUser, anduseSessionreport it, and one button for each screen a test needs.screens/destinations.tsis the one table of those buttons. The host draws nothing on or aroundAuthView,UserButton, orUserProfileView. A launch with noverifyinput shows the same home, signed out, with the publishable key the app was built with.The inputs are launch arguments on iOS (
-verifyAuthMode signIn) and string extras on Android (--es verifyAuthMode signIn). The native modulemodules/verify-launch-configreads them, in under 50 lines per platform.verifyAuthModeissignIn,signUp, orsignInOrUpfor everyAuthViewthe home opens.verifySignInTicketsigns in with the ticket strategy once Clerk has loaded, before the home renders.verifyStorageScopeclears stored Clerk state when its value differs from the last launch. On iOS it deletes the app's generic-password keychain items and the identifier thatAuthViewkeeps inUserDefaults. On Android it deletes theclerk_preferencesandSecureStorepreferences.verifyPublishableKeyoverridesEXPO_PUBLIC_CLERK_PUBLISHABLE_KEY.verifyLogLevel debuglogs each request as its method, its URL without the query, and its status.verifyRunIdandverifyLaunchIdlabel the host's console lines. On iOS,verifyLaunchIdalso setsCLERK_E2E_MODE=1, which keeps password AutoFill off the fields of the native Clerk views.The second commit deletes the older tests in
integration/tests/expo-native/, because they drive the home thatApp.tsxno longer has. Their config, page objects, root scripts, the root dev dependenciese2eand@e2e-dev/mobile,scripts/resolve-instance-keys.mjs, and the steps of theExpoworkflow that ran them go with them. Each of their flows has a test in #10236.To review, read
verify/VerifyHost.tsxfirst, thenverify/launch.tsand the two files of the native module, thenscreens/Home.tsx. Nothing here is copied or generated, apart from three lines ofpnpm-lock.yaml.These need a decision from a reviewer:
app.jsonnow lists the@clerk/expo-google-signinconfig plugin, with placeholder client IDs that belong to no Google project. The tarball builds of theExpoworkflow on SDK 54, 55, and 57 now run that plugin.Expoworkflow's jobsNative E2E (<platform>, sdk 57)becomeNative Build (<platform>, sdk 57). A branch rule that names aNative E2Echeck needs the new name before this merges.Two smaller build changes come with it.
metro.config.jswatches the monorepo only whennode_modules/@clerk/expolinks topackages/expo, so a tarball install keeps the default config. For SDK 57 only,package.sdk-57.jsonaddsexpo-build-propertiesand movesexpoto~57.0.23, andapp.config.jsturns onios.enableSceneSupport.pnpm install --frozen-lockfile --lockfile-onlypasses on this branch. The fixture runs on a device in the device suite of #10237. That suite passed on both platforms on the tree that the top of this stack had before two review fixes in #10237, in run 38601882313 of #10230.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
🤖 Generated with Claude Code