Repository navigation
Conversation
Every committed e2e test of `integration/expo-native/` lives in this folder, so "golden" had come to mean "committed". The folder now has the name of the skill's feature map. The CLI finds the tests in the new folder, and the spec kind `golden` is now `committed`. The kind is in the output of `run --json` and in `run.json`. No verb, flag, exit code or rule of discovery changes. The 13 files moved with no change to their content. The changeset is empty, as it is in the other pull requests of the stack. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The skill, the docs, the workflow, one CLI message and three test names called the committed e2e tests "golden". They are e2e tests. Where a sentence sets them against a scratch spec under `specs/explored/`, it says "committed spec". The workflow changes on one line, the name of the step that runs the tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 5e12c30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
mikepitre
added this pull request to stack #10100
October 14, 2026 02:04
This was referenced Oct 14, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the same change as clerk/clerk-ios#693, for the Expo package in
integration/expo-native/. clerk/clerk-android#1090 is the same change for clerk-android. This PR sits on #10221.Every committed e2e test lives in
integration/expo-native/specs/golden/<feature>/, so "golden" had come to mean "committed". The tests are e2e tests, and the folder will hold more of them.After this PR:
integration/expo-native/specs/golden/isintegration/expo-native/specs/features/, the name of the feature map in.claude/skills/verify-clerk-expo/features/. The 13 files moved with no change to their content.specs/explored/, the folder for scratch specs that git ignores, keeps its name.run --jsonand inrun.json, thekindof a committed spec iscommitted. It wasgolden.integration/expo-native/README.md, one CLI message and three test names say "e2e test". Where a sentence sets a committed test against a scratch spec, it says "committed spec"..github/workflows/verify-e2e.ymlchanges on one line, the name of the step that runs the tests.Behavior does not change.
run <feature>runs every spec of that feature, andrun --allruns every committed spec and no scratch spec. No verb, flag, exit code or rule of discovery changes. No tracked file of this repository holds the word "golden" after this.The files under
integration/expo-native/src/core/are byte copies of the files of clerk/clerk-ios#693. The changeset is empty, as it is in the other PRs of the stack. No published package changes.The same tests are found before and after. What
run --all,run <feature>,run <feature>/<spec>andrun <path>select, and whatnpx e2e listprints for those files, is 12 spec files, 17 tests on iOS and 15 on Android, on #10221 and on this branch. The two lists differ only in the name of the folder.npm testinintegration/expo-native/passes 793 of 793, as it does on #10221.npm run typecheckis clean.vitest run --root scripts verify-attachpasses 196 of 196.verify-e2erun 38495475457 on this head ran 17 tests on iOS and 15 on Android, in the 12 files fromspecs/features/, and all passed. The last run below this change, 38483444520 on #10219, ran the same 32. #10221 is a draft, so its own run skipped the tests, and it changes no file underspecs/.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
🤖 Generated with Claude Code