Remove generated recommendations from findings schema#66
Merged
Kiran01bm merged 1 commit intoblock:mainfrom Apr 30, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
bakayolo
force-pushed
the
fix/lambda-runtime-family-recommendations
branch
2 times, most recently
from
41ecd33 to
f176dc7
Compare
bakayolo
force-pushed
the
fix/lambda-runtime-family-recommendations
branch
from
f176dc7 to
f3c0a94
Compare
bakayolo
changed the title
Kiran01bm
approved these changes
Apr 30, 2026
Kiran01bm
added a commit
that referenced
this pull request
Apr 30, 2026
This was referenced Apr 30, 2026
Merged
Kiran01bm
added a commit
that referenced
this pull request
Apr 30, 2026
Kiran01bm
added a commit
that referenced
this pull request
Apr 30, 2026
## What and Why ? Follow-up to the deletes-only fix that landed alongside #66. PR #66 added a new `IsDeprecatedSupport` branch to `getYellowMessage` (Lambda-style "Standard Support" / "Deprecated Support" semantics) plus the `versionSubject` and `isLambda` helpers, but no tests were added at the time. The deletes-only fix dropped policy coverage from 98.8% → 96.0% because it removed the `GetRecommendation` test surface that #66 had already deleted; this PR recovers that coverage by exercising the new branch instead. ## Tests added | Test | Branch covered | |------|----------------| | `TestGetMessage_Yellow_DeprecatedSupport_WithEOL` | Lambda runtime in deprecated support **with** an end date — exercises the `IsDeprecatedSupport`+`EOLDate` path and `versionSubject`'s `"Runtime"` label (via `isLambda`) | | `TestGetMessage_Yellow_DeprecatedSupport_NoEOL` | `IsDeprecatedSupport` **without** an end date — non-Lambda resource, so `versionSubject` returns `"Version"`; asserts the until-phrase is omitted | ## Verification All commands run with `GOTOOLCHAIN=go1.24.2`: - `go test ./pkg/policy/... -cover` → **98.7%** (up from 96.0%) - `go test ./...` → all packages green - `golangci-lint run ./...` → 0 findings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing