Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7fc85d2c69
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - **Lambda (`aws-lambda`)** — uses "Standard Support" / | ||
| "Deprecated Support" instead of `extendedSupport`. The | ||
| deprecated-support window maps onto Version Guard's YELLOW | ||
| extended-support state. |
There was a problem hiding this comment.
Remove incorrect claim that Lambda uses declarative schema
This section says Lambda is a currently shipped schema: declarative resource, but the live default config defines lambda with schema: standard and no eol.lifecycle (pkg/config/defaults/resources.yaml lines 314-320). That mismatch will mislead anyone following the skill to model Lambda-like products as declarative when the repository’s actual pattern is standard, causing incorrect guidance and inconsistent configs.
Useful? React with 👍 / 👎.
| | ElastiCache Redis | `"elastiCache/Redis/cluster"` | | ||
| | ElastiCache Valkey | `"elastiCache/Valkey/cluster"` | | ||
| | ElastiCache Memcached | `"elastiCache/Memcached/cluster"` | | ||
| | OpenSearch | `"elasticSearchService\|OpenSearch Domain"` | |
There was a problem hiding this comment.
Use unescaped OpenSearch alternation pattern in example table
The table shows native_type_pattern as elasticSearchService\|OpenSearch Domain, but the matcher in pkg/inventory/wiz/generic.go splits on literal | and does exact string comparison on each side. If users copy this escaped form, the first alternative becomes elasticSearchService\ and will never match, silently dropping Elasticsearch-native rows.
Useful? React with 👍 / 👎.
|
the test failures will be fixed in a subsequent pr - its a fall out from #66 |
What and Why ?
The
add-version-guard-resourceskill was added in #33 and only had twoincidental touches since (#57, #63), but ~10 intervening PRs changed the
formats / schemas / workflows it teaches. Walked the skill end-to-end
against current
resources.yaml+loader.goand fixed everystaleness an agent would hit today.
Markdown-only. No code changes.
Fixes
SKILL.mdStep 1 (no-product STOP)SKILL.mdStep 3 (native_type_patternexamples)rds/AmazonAurora*/cluster,eks/Cluster,elastiCache/*/clusterresources.yaml+ note that*only matches whole path segments (partial-segment globs silently match nothing)SKILL.mdStep 4 (schema overview)supported; accurate loader behavior (loader auto-fillsschema: declarativewhenlifecycle:is present)SKILL.mdStep 6 (OpenSearch example)native_type_pattern: "opensearch/Domain""elasticSearchService|OpenSearch Domain"(old value matched zero rows)SKILL.mdStep 6 (examples menu)elasticache.yaml= "wildcard patterns"SKILL.mdCompletionreferences/troubleshooting.md("Non-Standard Schema")schema: {resource}-adapter+ "refer to EKS adapter"schema: declarative+lifecycle:block, link toADAPTERS.md; EKS Go adapter no longer existsSKILL.mdStep 7 footerDriving PRs since #33
#36, #38, #42, #44, #45, #53, #54, #56, #62, #63.