Skip to content

chore: refresh ai-skill#67

Merged
Kiran01bm merged 2 commits intomainfrom
kiran01bm-skills-refresh
Apr 30, 2026
Merged

chore: refresh ai-skill#67
Kiran01bm merged 2 commits intomainfrom
kiran01bm-skills-refresh

Conversation

@Kiran01bm
Copy link
Copy Markdown
Contributor

What and Why ?

The add-version-guard-resource skill was added in #33 and only had two
incidental touches since (#57, #63), but ~10 intervening PRs changed the
formats / schemas / workflows it teaches. Walked the skill end-to-end
against current resources.yaml + loader.go and fixed every
staleness an agent would hit today.

Markdown-only. No code changes.

Fixes

Spot Was Now
SKILL.md Step 1 (no-product STOP) Stop on any missing product Fall back to upstream product when AWS-flavored is missing (Valkey / Memcached pattern from #53); only stop if no product exists at all
SKILL.md Step 3 (native_type_pattern examples) rds/AmazonAurora*/cluster, eks/Cluster, elastiCache/*/cluster Actual current patterns from resources.yaml + note that * only matches whole path segments (partial-segment globs silently match nothing)
SKILL.md Step 4 (schema overview) Standard = 3 fields; declarative = "EKS only" Three real cycle shapes the standard adapter handles; declarative covers EKS and Lambda; inline lifecycle block; full field/action set incl. supported; accurate loader behavior (loader auto-fills schema: declarative when lifecycle: is present)
SKILL.md Step 6 (OpenSearch example) native_type_pattern: "opensearch/Domain" "elasticSearchService|OpenSearch Domain" (old value matched zero rows)
SKILL.md Step 6 (examples menu) elasticache.yaml = "wildcard patterns" Per-engine split (#53); the example file itself warns against wildcard + single product
SKILL.md Completion Steered toward Go adapter Steers toward declarative YAML; Go adapter is now exceptional (#63)
references/troubleshooting.md ("Non-Standard Schema") schema: {resource}-adapter + "refer to EKS adapter" schema: declarative + lifecycle: block, link to ADAPTERS.md; EKS Go adapter no longer exists
SKILL.md Step 7 footer "Proceed to Step 7" "Proceed to Step 8"

Driving PRs since #33

#36, #38, #42, #44, #45, #53, #54, #56, #62, #63.

@Kiran01bm Kiran01bm requested a review from a team as a code owner April 30, 2026 03:06
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7fc85d2c69

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +231 to +234
- **Lambda (`aws-lambda`)** — uses "Standard Support" /
"Deprecated Support" instead of `extendedSupport`. The
deprecated-support window maps onto Version Guard's YELLOW
extended-support state.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove incorrect claim that Lambda uses declarative schema

This section says Lambda is a currently shipped schema: declarative resource, but the live default config defines lambda with schema: standard and no eol.lifecycle (pkg/config/defaults/resources.yaml lines 314-320). That mismatch will mislead anyone following the skill to model Lambda-like products as declarative when the repository’s actual pattern is standard, causing incorrect guidance and inconsistent configs.

Useful? React with 👍 / 👎.

| ElastiCache Redis | `"elastiCache/Redis/cluster"` |
| ElastiCache Valkey | `"elastiCache/Valkey/cluster"` |
| ElastiCache Memcached | `"elastiCache/Memcached/cluster"` |
| OpenSearch | `"elasticSearchService\|OpenSearch Domain"` |
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use unescaped OpenSearch alternation pattern in example table

The table shows native_type_pattern as elasticSearchService\|OpenSearch Domain, but the matcher in pkg/inventory/wiz/generic.go splits on literal | and does exact string comparison on each side. If users copy this escaped form, the first alternative becomes elasticSearchService\ and will never match, silently dropping Elasticsearch-native rows.

Useful? React with 👍 / 👎.

@Kiran01bm
Copy link
Copy Markdown
Contributor Author

the test failures will be fixed in a subsequent pr - its a fall out from #66

@Kiran01bm Kiran01bm merged commit c514a91 into main Apr 30, 2026
6 of 7 checks passed
@Kiran01bm Kiran01bm deleted the kiran01bm-skills-refresh branch April 30, 2026 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants