test(policy): cover new IsDeprecatedSupport Yellow branch#69
Merged
Conversation
bakayolo
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and Why ?
Follow-up to the deletes-only fix that landed alongside #66. PR #66 added
a new
IsDeprecatedSupportbranch togetYellowMessage(Lambda-style"Standard Support" / "Deprecated Support" semantics) plus the
versionSubjectandisLambdahelpers, but no tests were added at thetime. The deletes-only fix dropped policy coverage from 98.8% → 96.0%
because it removed the
GetRecommendationtest surface that #66 hadalready deleted; this PR recovers that coverage by exercising the new
branch instead.
Tests added
TestGetMessage_Yellow_DeprecatedSupport_WithEOLIsDeprecatedSupport+EOLDatepath andversionSubject's"Runtime"label (viaisLambda)TestGetMessage_Yellow_DeprecatedSupport_NoEOLIsDeprecatedSupportwithout an end date — non-Lambda resource, soversionSubjectreturns"Version"; asserts the until-phrase is omittedVerification
All commands run with
GOTOOLCHAIN=go1.24.2:go test ./pkg/policy/... -cover→ 98.7% (up from 96.0%)go test ./...→ all packages greengolangci-lint run ./...→ 0 findings