Skip to content

feat: add gh workflows setup#1748

Merged
Hweinstock merged 14 commits into
aws:refactorfrom
Hweinstock:feat/add-workflows
Jul 15, 2026
Merged

feat: add gh workflows setup#1748
Hweinstock merged 14 commits into
aws:refactorfrom
Hweinstock:feat/add-workflows

Conversation

@Hweinstock

@Hweinstock Hweinstock commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

built on #1747.
Direct port of AlexanderRichey/agentcore-cli#5.

Problem

The refactor is missing CI and a pattern for GH workflows. There are no automated checks on PRs, or on merge to main.

The existing CLI does not have a consistent pattern for workflows, which results in a large amount of duplication. Ex. e2e-tests logic duplicated across push-pr, and release duplicates much of release main.

Solution

Testing

Running commands locally I can confirm all pass except test and typecheck (which are also failing upstream).

Notes

  • sharding is left as a follow-up, but confirmed the existing pattern in the CLI is supported in bun.

Future Work

  • potentially add hooks on workflows that posts CWL metrics. We can then leverage this for ticketing (for canary failures or CI failures on main) and dashboards to track health over time. (depends if migrating to codebuild gives us this for free)

@github-actions github-actions Bot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Jul 13, 2026
@Hweinstock

Copy link
Copy Markdown
Contributor Author

See #1745 (comment) for more info on CI.

@Hweinstock Hweinstock force-pushed the feat/add-workflows branch from 723e500 to da0ca58 Compare July 13, 2026 16:07
@Hweinstock Hweinstock changed the title feat: add gh workflows setup (wip) feat: add gh workflows setup Jul 13, 2026
@Hweinstock Hweinstock force-pushed the feat/add-workflows branch 2 times, most recently from 415223a to ffc0452 Compare July 13, 2026 17:18
@Hweinstock Hweinstock changed the title (wip) feat: add gh workflows setup feat: add gh workflows setup Jul 13, 2026
@Hweinstock

Copy link
Copy Markdown
Contributor Author

Note: CI is failing before these changes.
typecheck issues pre-existing on main.

bun build ./src/index.ts --target node --outdir ./dist --minify
7 | import devtools from 'react-devtools-core';
                         ^
error: Could not resolve: "react-devtools-core". Maybe you need to "bun install"?
    at /home/runner/work/agentcore-cli/agentcore-cli/node_modules/ink/build/devtools.js:7:22
error: script "build" exited with code 1

Existing issue due to react-devtools-core missing from dev deps.

Run bun run build
$ bun build ./src/index.ts --target node --outdir ./dist --minify
7 | import devtools from 'react-devtools-core';
                         ^
error: Could not resolve: "react-devtools-core". Maybe you need to "bun install"?
    at /home/runner/work/agentcore-cli/agentcore-cli/node_modules/ink/build/devtools.js:7:22
error: script "build" exited with code 1

Existing issue due to missing default. see https://typicode.github.io/husky/how-to.html#ci-server-and-docker.

@Hweinstock

Copy link
Copy Markdown
Contributor Author

Two issues for follow-up since they are OOS of this PR:

@Hweinstock Hweinstock force-pushed the feat/add-workflows branch from afa7953 to 5ef71e3 Compare July 14, 2026 14:17
@codecov-commenter

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

nborges-aws
nborges-aws previously approved these changes Jul 14, 2026
@Hweinstock Hweinstock marked this pull request as ready for review July 14, 2026 20:00
@Hweinstock

Hweinstock commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Failing typecheck is fixed in #1756.

@notgitika notgitika left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation on why the workflows are failing.

I have a question, why are these workflows back to using GH based runners ubuntu-latest and not the codebuild ones introduced in #1715

is this intentional? is there a plan to switch it back to the codebuild ones once merged to main? if so, please add a backlog comment here

@notgitika notgitika left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for creating the issue. LGTM!

@Hweinstock

Copy link
Copy Markdown
Contributor Author

Ahh good callout, I didn't realize we were already fully on codebuild. I mostly setup with GH actions for simplicity, and to get something running quickly.

Since CI currently doesn't exist on this branch and I've got some changes based on this here, I think I'm going to merge and take this as a fast follow. I created a issue and assigned it to myself here: #1772

@Hweinstock Hweinstock merged commit b5e68f8 into aws:refactor Jul 15, 2026
2 of 4 checks passed
@Hweinstock Hweinstock deleted the feat/add-workflows branch July 15, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants