feat: add gh workflows setup#1748
Conversation
|
See #1745 (comment) for more info on CI. |
723e500 to
da0ca58
Compare
415223a to
ffc0452
Compare
|
Note: CI is failing before these changes. Existing issue due to Existing issue due to missing default. see https://typicode.github.io/husky/how-to.html#ci-server-and-docker. |
34e8bcb to
afa7953
Compare
|
Two issues for follow-up since they are OOS of this PR:
|
afa7953 to
5ef71e3
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
2011135 to
1686f84
Compare
|
Failing typecheck is fixed in #1756. |
notgitika
left a comment
There was a problem hiding this comment.
Thanks for the explanation on why the workflows are failing.
I have a question, why are these workflows back to using GH based runners ubuntu-latest and not the codebuild ones introduced in #1715
is this intentional? is there a plan to switch it back to the codebuild ones once merged to main? if so, please add a backlog comment here
notgitika
left a comment
There was a problem hiding this comment.
thanks for creating the issue. LGTM!
|
Ahh good callout, I didn't realize we were already fully on codebuild. I mostly setup with GH actions for simplicity, and to get something running quickly. Since CI currently doesn't exist on this branch and I've got some changes based on this here, I think I'm going to merge and take this as a fast follow. I created a issue and assigned it to myself here: #1772 |
built on #1747.
Direct port of AlexanderRichey/agentcore-cli#5.
Problem
The refactor is missing CI and a pattern for GH workflows. There are no automated checks on PRs, or on merge to main.
The existing CLI does not have a consistent pattern for workflows, which results in a large amount of duplication. Ex. e2e-tests logic duplicated across push-pr, and release duplicates much of release main.
Solution
Testing
Running commands locally I can confirm all pass except test and typecheck (which are also failing upstream).
Notes
Future Work