fix(ci): address failing typechecker#1756
Open
Hweinstock wants to merge 12 commits into
Open
Conversation
github-actions
Bot
added
agentcore-harness-reviewing
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor #1756 +/- ##
===========================================
Coverage ? 93.59%
===========================================
Files ? 115
Lines ? 6683
Branches ? 0
===========================================
Hits ? 6255
Misses ? 428
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
CodeCov is failing because it can't find the base commit since earlier PR that adds it is not merged. |
nborges-aws
changed the title
nborges-aws
previously approved these changes
Jul 14, 2026
Hweinstock
force-pushed
the
fix/typecheck
branch
2 times, most recently
from
983b7c1 to
93a3e9e
Compare
Hweinstock
commented
Jul 15, 2026
| if (col.width) return col.width; | ||
| // default the width of each column | ||
| const columnsWithWidths = columns.map((col) => { | ||
| if (col.width !== undefined) return { ...col, width: col.width }; |
Contributor
Author
There was a problem hiding this comment.
we explicitly check undefined to fix the edge case where the width is explicitly set to 0
added 12 commits
July 15, 2026 23:49
Hweinstock
force-pushed
the
fix/typecheck
branch
from
93a3e9e to
357b7c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on #1748.
Problem
The typechecker is failing, see #1748 as an example.
The issues are isolated to the TUI code, and mostly resolve around missing undefined checks.
Solution
Testing
bun run typecheck.Also passing in CI.