Skip to content

add SKILL.md and zh-CN agent skill instruction#62059

Merged
jason810496 merged 7 commits intoapache:mainfrom
sjyangkevin:issues/62004/airflow-translations-agent-skill-zh-CN
Feb 19, 2026
Merged

add SKILL.md and zh-CN agent skill instruction#62059
jason810496 merged 7 commits intoapache:mainfrom
sjyangkevin:issues/62004/airflow-translations-agent-skill-zh-CN

Conversation

@sjyangkevin
Copy link
Contributor

@sjyangkevin sjyangkevin commented Feb 17, 2026


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: [Antigravity] following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM overall for the global level index translation skill.

I would like to see more inputs/suggestions from other maintainers that might be interested in

cc @potiuk @shahar1 @jscheffl @choo121600

Thanks!

@jason810496 jason810496 added area:translations translation:zh-CN and removed area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Feb 17, 2026
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Few nits.

Copy link
Member

@choo121600 choo121600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good and reasonable structure. LGTM overall 👍

@sjyangkevin
Copy link
Contributor Author

Thanks!! I also noticed a PR from @Aditi102005 introduce a SKILL.md as well. @Aditi102005 would you mind check this proposal and share if you have any feedback.

@sjyangkevin sjyangkevin force-pushed the issues/62004/airflow-translations-agent-skill-zh-CN branch 2 times, most recently from 7eae4dc to 52f9dce Compare February 17, 2026 18:21
@sjyangkevin
Copy link
Contributor Author

sorry, it looks the branch is somehow diverged.. i will take some time to resolve it

@sjyangkevin sjyangkevin force-pushed the issues/62004/airflow-translations-agent-skill-zh-CN branch from eec1541 to afd02e1 Compare February 17, 2026 18:30
Copy link
Contributor Author

@sjyangkevin sjyangkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @potiuk , @jason810496 , @choo121600 , I just made an update based on the review feedback. Could you have a second look at this, and let me know if you have further feedback. Thanks!

@sjyangkevin sjyangkevin marked this pull request as ready for review February 17, 2026 19:44
@sjyangkevin sjyangkevin force-pushed the issues/62004/airflow-translations-agent-skill-zh-CN branch from 687e0c6 to 9c40390 Compare February 18, 2026 19:01
@sjyangkevin sjyangkevin changed the title add SKILL.md and zh-CN agent skill instruction [WIP] add SKILL.md and zh-CN agent skill instruction Feb 18, 2026
@sjyangkevin
Copy link
Contributor Author

sorry team.. I made a mistake when rebasing the branch.

@sjyangkevin sjyangkevin force-pushed the issues/62004/airflow-translations-agent-skill-zh-CN branch from 9c40390 to 8681fd1 Compare February 18, 2026 19:13
@sjyangkevin sjyangkevin changed the title [WIP] add SKILL.md and zh-CN agent skill instruction add SKILL.md and zh-CN agent skill instruction Feb 18, 2026
@sjyangkevin sjyangkevin force-pushed the issues/62004/airflow-translations-agent-skill-zh-CN branch from 1cad76e to 2aa213d Compare February 18, 2026 22:05
@jason810496 jason810496 merged commit b5e546d into apache:main Feb 19, 2026
71 checks passed
@jason810496
Copy link
Member

Thanks @sjyangkevin for the great proposal for the global translation skill! I just merged this as a reference for all the other locales, and we can keep iterating on it for sure. Thanks again Kevin, for actively updating it to address all the comments!

@sjyangkevin
Copy link
Contributor Author

Thanks @jason810496 to bring up this initiative, and all for the feedback. Definitely we can continue on iterating on it.

I also want to check if we should refine the pre-commit (prek) hook to add shorten license to the SKILL.md, after the YAML formatter. Maybe that can benefit future skills if any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define translation agent skill guidelines for Simplified Chinese (zh-CN) locale

5 participants

Comments