Skip to content

Feat ja translation skill#62086

Open
HARDIK-WEB-OSS wants to merge 2 commits intoapache:mainfrom
HARDIK-WEB-OSS:feat-ja-translation-skill
Open

Feat ja translation skill#62086
HARDIK-WEB-OSS wants to merge 2 commits intoapache:mainfrom
HARDIK-WEB-OSS:feat-ja-translation-skill

Conversation

@HARDIK-WEB-OSS
Copy link

Description

closes: #61997
related: #61984

Defined translation agent skills for the Japanese (ja) locale according to #62059.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
    Generated-by: [Gemini] following the guidelines

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools area:providers backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch provider:google Google (including GCP) related issues labels Feb 17, 2026
@HARDIK-WEB-OSS HARDIK-WEB-OSS force-pushed the feat-ja-translation-skill branch from ae79d92 to 5283b59 Compare February 18, 2026 08:56
@HARDIK-WEB-OSS
Copy link
Author

Hi @shahar1 and @Dev-iL, I have reverted the unrelated BigQuery changes as suggested. I have also updated the license header to include the URL per the feedback. My branch is now clean and only contains the Japanese locale translation agent skill. Ready for another look!

@Dev-iL
Copy link
Collaborator

Dev-iL commented Feb 18, 2026

I have also updated the license header to include the URL per the feedback.

I still don't see it.

@HARDIK-WEB-OSS
Copy link
Author

Hi @Dev-iL and @shahar1, I've fixed the license header to the minimal 3-line format as per the feedback. I've also squashed the commits and cleaned the branch history. Re-opened and ready for a final review.

Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all Japanese translation owners, I’d appreciate it if you could take a look when you have a moment. Thank you!

cc @uranusjr @sekikn @rsanda

@jason810496 jason810496 added area:translations translation:ja and removed provider:google Google (including GCP) related issues area:providers area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Feb 18, 2026
@HARDIK-WEB-OSS
Copy link
Author

Hi @shahar1, I have resolved all conversations and Dev-iL has approved the changes. The PR is now clean, squashed, and up-to-date. Could you please trigger the workflows and provide the final review? Thanks!

@rsanda
Copy link
Contributor

rsanda commented Feb 19, 2026

Sorry for the delay and thanks for working on this.
The rules that are mentioned are correct, some missing ones that I set when translating:

Core Rules

  • Put a space before and after English words, numerical values, and half-width caracters if it is not at the beggining or end of the sentence.
  • Use the polite version of "desu/masu" when a user action is expected.

Terminology Guidelines

  • Keep "Providers" as there is no good translation
  • "Trigger" as "トリガー" but "Triggerer" is left as "Triggerer" since "トリガーラー" is not common and difficult to understand

@HARDIK-WEB-OSS HARDIK-WEB-OSS force-pushed the feat-ja-translation-skill branch from 921a38a to 3c52249 Compare February 19, 2026 17:32
@HARDIK-WEB-OSS
Copy link
Author

Thank you for the detailed feedback @rsanda ! I've updated the ja.md file to include:

  • The specific spacing rules for English words/numbers.
  • Updated terminology (Providers, Trigger, and Triggerer) exactly as you mentioned.
  • Re-emphasized the 'Desu/Masu' rule for user actions.

The PR is now updated and ready for final review.

@shahar1 shahar1 requested review from sekikn and uranusjr February 19, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define translation agent skill guidelines for Japanese (ja) locale

5 participants

Comments