feat: Onboarding Welcome Page#2435
Open
camielvs wants to merge 2 commits into
Open
Conversation
🎩 PreviewA preview build has been created at: |
This was referenced Jun 18, 2026
Collaborator
Author
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
2 times, most recently
from
be1cab9 to
475b1de
Compare
camielvs
changed the base branch from
06-17-feat_onboarding_checklist
to
graphite-base/2435
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
475b1de to
b2ef001
Compare
camielvs
changed the base branch from
graphite-base/2435
to
06-18-feat_onboarding_pill
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
33d4a5c to
c38d713
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
b2ef001 to
46b33cb
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
c38d713 to
5f5d39b
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
2 times, most recently
from
4833c25 to
a93cf71
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
5f5d39b to
c994062
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
a93cf71 to
e0ce7f1
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
2 times, most recently
from
bbdf96e to
5ea2aaa
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
e0ce7f1 to
8c45c84
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
2 times, most recently
from
8da83d6 to
fa0fbc4
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
eeefe26 to
7b70ec6
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
2 times, most recently
from
0d98bcd to
4172fc3
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
7b70ec6 to
601fa2a
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
4172fc3 to
b36f16e
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
601fa2a to
0da37a4
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
b36f16e to
2f5fd7c
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
0da37a4 to
5a2f860
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
2f5fd7c to
5cff5ee
Compare
camielvs
commented
Jun 19, 2026
camielvs
left a comment
camielvs
left a comment
Collaborator
Author
There was a problem hiding this comment.
Welcome route + IndexRedirect wrap up the series nicely. The split — routing on isReady (valid with no backend), sidebar on isResolved — matches the provider contract. Verified APP_ROUTES.DASHBOARD moving from / to /dashboard has no other call-sites depending on the old value. Two small inline notes.
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
5a2f860 to
b5d4e02
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
5cff5ee to
9167166
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
b5d4e02 to
f838ac6
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
9167166 to
4cef7e8
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
f838ac6 to
0b64d0e
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
4cef7e8 to
f0956cc
Compare
Mbeaulne
reviewed
Jun 25, 2026
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
2 times, most recently
from
97aa0d0 to
f772aea
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
61f4548 to
97f6ae5
Compare
- Gate OnboardingWelcome on !isReady with a spinner (match IndexRedirect) - Import APP_ROUTES from appRoutes instead of the router shim Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
camielvs
force-pushed
the
06-18-feat_onboarding_pill
branch
from
97f6ae5 to
9daead8
Compare
camielvs
force-pushed
the
06-18-feat_onboarding_welcome_page
branch
from
f772aea to
90f6e8b
Compare
maxy-shpfy
reviewed
Jun 26, 2026
|
|
||
| if (!isResolved) { | ||
| return ( | ||
| <BlockStack align="center" inlineAlign="center" className="h-full"> |
Collaborator
There was a problem hiding this comment.
🤖 This is an AI-generated code review comment.
The new redirect loading state passes className into a Tangle UI primitive for sizing. The project instructions explicitly reserve primitive styling for semantic props or a local Layer-3 pattern.
Suggestion: Use the primitive's semantic sizing API, e.g. <BlockStack fill>, and omit explicit alignment props when they match the fill defaults.
Rule: CLAUDE.md UI rule: never pass className to a Tangle UI primitive; ui-primitives skill: use semantic primitive props
maxy-shpfy
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Final PR in the onboarding series (stacked on #2440). Gives new users a dedicated landing experience instead of dropping them into an empty dashboard.
/welcomeroute — a focused, centered welcome page hosting the onboarding card, so onboarding doesn't take over the "My Dashboard" view.IndexRedirect) —/now resolves based on onboarding state: new users (onboarding not complete and not dismissed) go to/welcome; everyone else goes to/dashboard. The dashboard is moved off/to its own route so manual navigation to either still works.isResolvedto avoid flicker.Related Issue and Pull requests
Closes https://github.com/Shopify/oasis-frontend/issues/622
Stacked on #2421 → #2440
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
/— you should be redirected to/welcomewith the onboarding card centered in the available space./— you should land on/dashboard./welcomeand/dashboard— both should be reachable regardless of redirect logic./welcomeand confirm subsequent visits to/land on the dashboard.Additional Comments
Routing decisions wait on
isReady(queries settled, valid even with no backend) while the sidebar entry gates onisResolved, matching the provider contract introduced earlier in the stack.