Skip to content

feat: Learning Hub - Milestone 2#2416

Open
camielvs wants to merge 1 commit into
06-15-feat_guided_tours_cleanupfrom
06-12-feat_learning_hub_-_milestone_2
Open

feat: Learning Hub - Milestone 2#2416
camielvs wants to merge 1 commit into
06-15-feat_guided_tours_cleanupfrom
06-12-feat_learning_hub_-_milestone_2

Conversation

@camielvs

@camielvs camielvs commented Jun 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Removes the unnecessary fat from the guided tours mockup and turns it into a user-ready experience.

Removes:

  • uncreated tours
  • "popular" and "new" tags
  • pointless hover state on cards

Plus update tour durations

Related Issue and Pull requests

Closes https://github.com/Shopify/oasis-frontend/issues/584

Closes https://github.com/Shopify/oasis-frontend/issues/621

Closes https://github.com/Shopify/oasis-frontend/issues/583

Type of Change

  • New feature

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

image.png

Test Instructions

  • Confirm that all four new guided tours work as expected, including interactions, tinstructions and other features, and have minimal edge cases
  • Confirm that Tours are correctly marked as completed
  • Confirm that the tours page and UI is complete
  • Confirm that the existing V2 Editor and Pipelines continues to work as normal when not inside a tour

Additional Comments

@github-actions

github-actions Bot commented Jun 13, 2026 •
edited
Loading

Copy link
Copy Markdown

🎩 Preview

A preview build has been created at: 06-12-feat_learning_hub_-_milestone_2/01cfb6d

This was referenced Jun 13, 2026
Open
Open
Open
Open
Open
Open
Open
@camielvs Graphite App

camielvs commented Jun 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camielvs camielvs mentioned this pull request Jun 13, 2026
Open
3 tasks
@camielvs camielvs added the #gsd:50583 Learning Hub label Jun 13, 2026 — with Graphite App
@camielvs camielvs force-pushed the 06-12-feat_guided_tours_e2e_tests branch from f9ccfa0 to c1361f2 Compare June 15, 2026 17:55
@camielvs camielvs force-pushed the 06-12-feat_learning_hub_-_milestone_2 branch from 37e7483 to 1caa750 Compare June 15, 2026 17:55
@camielvs camielvs changed the base branch from 06-12-feat_guided_tours_e2e_tests to graphite-base/2416 June 15, 2026 17:57
@camielvs camielvs force-pushed the 06-12-feat_learning_hub_-_milestone_2 branch from 1caa750 to dcf45e8 Compare June 15, 2026 17:57
@camielvs camielvs changed the base branch from graphite-base/2416 to 06-15-feat_guided_tours_cleanup June 15, 2026 17:58
@camielvs camielvs mentioned this pull request Jun 15, 2026
Open
8 tasks
@camielvs camielvs force-pushed the 06-12-feat_learning_hub_-_milestone_2 branch from dcf45e8 to 36890cb Compare June 15, 2026 18:39
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from f11f8c5 to e3505bc Compare June 15, 2026 18:39
@camielvs camielvs force-pushed the 06-12-feat_learning_hub_-_milestone_2 branch from 36890cb to 33bcd9e Compare June 15, 2026 18:47
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch 2 times, most recently from 1674b0f to bc08155 Compare June 15, 2026 18:59
@camielvs camielvs force-pushed the 06-12-feat_learning_hub_-_milestone_2 branch 4 times, most recently from ec17201 to 99fc45b Compare June 15, 2026 19:49
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch 2 times, most recently from 9465f4f to e099377 Compare June 15, 2026 20:13
@camielvs camielvs force-pushed the 06-12-feat_learning_hub_-_milestone_2 branch from 99fc45b to 39fdb4d Compare June 15, 2026 20:13
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from e099377 to e8777f3 Compare June 15, 2026 22:34
@camielvs camielvs force-pushed the 06-12-feat_learning_hub_-_milestone_2 branch from 9e504c5 to 13a695f Compare June 16, 2026 01:27
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from 83a38f1 to e46e42f Compare June 16, 2026 01:31
@camielvs camielvs force-pushed the 06-12-feat_learning_hub_-_milestone_2 branch 2 times, most recently from dfb2fe4 to 6644e89 Compare June 16, 2026 17:19
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from e46e42f to 01015dc Compare June 16, 2026 17:19
@camielvs camielvs force-pushed the 06-12-feat_learning_hub_-_milestone_2 branch from 6644e89 to a72ba22 Compare June 16, 2026 18:35
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch 2 times, most recently from 0f926fe to 9d81435 Compare June 16, 2026 19:12
@camielvs camielvs force-pushed the 06-12-feat_learning_hub_-_milestone_2 branch 2 times, most recently from 6059aca to 00bd0c8 Compare June 16, 2026 19:21
@camielvs camielvs marked this pull request as ready for review June 16, 2026 19:33
@camielvs camielvs requested a review from a team as a code owner June 16, 2026 19:33
@camielvs camielvs force-pushed the 06-12-feat_learning_hub_-_milestone_2 branch from 00bd0c8 to 65047a8 Compare June 17, 2026 17:24
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from 9d81435 to 2291b55 Compare June 17, 2026 17:24
This was referenced Jun 17, 2026
Open
Open
Open
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from 2291b55 to c43b025 Compare June 19, 2026 02:25
@camielvs camielvs force-pushed the 06-12-feat_learning_hub_-_milestone_2 branch 3 times, most recently from f6fe1e5 to ab71553 Compare June 19, 2026 21:48
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from 7618521 to aeba38f Compare June 19, 2026 21:48
@camielvs camielvs force-pushed the 06-12-feat_learning_hub_-_milestone_2 branch 2 times, most recently from c1e70ec to f8a3078 Compare June 26, 2026 00:37
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from 2b646c2 to 49b4606 Compare June 26, 2026 00:37
@camielvs camielvs force-pushed the 06-15-feat_guided_tours_cleanup branch from 49b4606 to 78e5321 Compare June 26, 2026 00:53
@camielvs camielvs force-pushed the 06-12-feat_learning_hub_-_milestone_2 branch from f8a3078 to 01cfb6d Compare June 26, 2026 00:53
maxy-shpfy
maxy-shpfy reviewed Jun 26, 2026
View reviewed changes
Comment thread src/components/Learn/TourCompletedBadge.tsx

export function TourCompletedBadge() {
return (
<Badge size="sm" variant="outline" className="text-green-600">

@maxy-shpfy maxy-shpfy Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 This is an AI-generated code review comment.

The extracted completed-state badge centralizes the repeated markup, which is good, but the new component still passes a Tailwind color class directly into the Badge primitive. The Tangle UI primitive rule says not to style primitives through className; color intent should be represented by a semantic prop/variant or a Layer-3 pattern so visual language stays centralized.

Suggestion: Add/use a semantic completed/success badge variant or a small Layer-3 CompletedBadge pattern that owns the success styling without callers passing className to the primitive.

Rule: tangle-ui-review checklist §6 / project UI primitives rule: never pass className to a Tangle UI primitive; use semantic props or Layer-3 patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxy-shpfy maxy-shpfy maxy-shpfy approved these changes

Assignees

No one assigned

Labels

#gsd:50583 Learning Hub

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camielvs @maxy-shpfy