feat: Guided Tours Cleanup#2417
Open
camielvs wants to merge 1 commit into
Open
Conversation
🎩 PreviewA preview build has been created at: |
This was referenced Jun 15, 2026
Collaborator
Author
3 tasks
camielvs
force-pushed
the
06-15-feat_guided_tours_cleanup
branch
2 times, most recently
from
e3505bc to
1674b0f
Compare
camielvs
force-pushed
the
06-12-feat_guided_tours_e2e_tests
branch
2 times, most recently
from
088f063 to
ef6a2d0
Compare
camielvs
force-pushed
the
06-15-feat_guided_tours_cleanup
branch
from
1674b0f to
bc08155
Compare
camielvs
force-pushed
the
06-12-feat_guided_tours_e2e_tests
branch
from
ef6a2d0 to
b583f84
Compare
camielvs
force-pushed
the
06-15-feat_guided_tours_cleanup
branch
from
bc08155 to
3559d73
Compare
camielvs
force-pushed
the
06-12-feat_guided_tours_e2e_tests
branch
from
b583f84 to
cf0a129
Compare
camielvs
force-pushed
the
06-15-feat_guided_tours_cleanup
branch
2 times, most recently
from
7cff3f0 to
9465f4f
Compare
camielvs
force-pushed
the
06-12-feat_guided_tours_e2e_tests
branch
from
cf0a129 to
03beccf
Compare
camielvs
force-pushed
the
06-15-feat_guided_tours_cleanup
branch
from
9465f4f to
e099377
Compare
camielvs
force-pushed
the
06-12-feat_guided_tours_e2e_tests
branch
from
03beccf to
d725087
Compare
camielvs
force-pushed
the
06-15-feat_guided_tours_cleanup
branch
from
e099377 to
e8777f3
Compare
camielvs
force-pushed
the
06-12-feat_guided_tours_e2e_tests
branch
from
d725087 to
94310c5
Compare
camielvs
force-pushed
the
06-15-feat_guided_tours_cleanup
branch
from
e8777f3 to
d9f058b
Compare
camielvs
force-pushed
the
06-12-feat_guided_tours_e2e_tests
branch
from
94310c5 to
515a226
Compare
camielvs
force-pushed
the
06-15-feat_guided_tours_cleanup
branch
from
d9f058b to
84e7368
Compare
camielvs
force-pushed
the
06-12-feat_guided_tours_e2e_tests
branch
from
515a226 to
e2d29d7
Compare
camielvs
force-pushed
the
06-15-feat_guided_tours_cleanup
branch
2 times, most recently
from
83a38f1 to
e46e42f
Compare
camielvs
force-pushed
the
06-12-feat_guided_tours_e2e_tests
branch
from
fb6be72 to
afe48e8
Compare
camielvs
force-pushed
the
06-15-feat_guided_tours_cleanup
branch
2 times, most recently
from
01015dc to
0f926fe
Compare
camielvs
force-pushed
the
06-12-feat_guided_tours_e2e_tests
branch
from
afe48e8 to
467fa3c
Compare
camielvs
force-pushed
the
06-15-feat_guided_tours_cleanup
branch
from
0f926fe to
9d81435
Compare
camielvs
force-pushed
the
06-12-feat_guided_tours_e2e_tests
branch
from
467fa3c to
9073078
Compare
camielvs
force-pushed
the
06-12-feat_guided_tours_e2e_tests
branch
from
9073078 to
be78ffa
Compare
camielvs
force-pushed
the
06-15-feat_guided_tours_cleanup
branch
from
9d81435 to
2291b55
Compare
This was referenced Jun 17, 2026
camielvs
force-pushed
the
06-15-feat_guided_tours_cleanup
branch
from
2291b55 to
c43b025
Compare
camielvs
force-pushed
the
06-12-feat_guided_tours_e2e_tests
branch
2 times, most recently
from
30f2eac to
b8fa57d
Compare
camielvs
force-pushed
the
06-15-feat_guided_tours_cleanup
branch
2 times, most recently
from
7618521 to
aeba38f
Compare
camielvs
force-pushed
the
06-12-feat_guided_tours_e2e_tests
branch
2 times, most recently
from
84979cf to
a795168
Compare
camielvs
force-pushed
the
06-15-feat_guided_tours_cleanup
branch
from
aeba38f to
2b646c2
Compare
camielvs
force-pushed
the
06-12-feat_guided_tours_e2e_tests
branch
from
a795168 to
02bc46f
Compare
camielvs
force-pushed
the
06-15-feat_guided_tours_cleanup
branch
from
2b646c2 to
49b4606
Compare
camielvs
force-pushed
the
06-12-feat_guided_tours_e2e_tests
branch
from
02bc46f to
d723728
Compare
camielvs
force-pushed
the
06-15-feat_guided_tours_cleanup
branch
from
49b4606 to
78e5321
Compare
maxy-shpfy
reviewed
Jun 26, 2026
| return event.target instanceof Element ? event.target : null; | ||
| } | ||
|
|
||
| /** |
Collaborator
There was a problem hiding this comment.
🤖 This is an AI-generated code review comment.
The new JSDoc blocks mostly narrate what watchValue and watchSelector already say through their names and signatures. Project standards ask for minimal comments that explain non-obvious why, not what; these add maintenance noise in a new utility file.
Suggestion: Remove the JSDoc blocks, or replace them with a short comment only if there is a non-obvious MobX/MutationObserver caveat worth preserving.
Rule: Project conventions / .cursorrules: comments should explain why, not restate what; keep comments minimal.
maxy-shpfy
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Additional Comments