Skip to content

test(browser): lock in domcontentloaded defaults for browser_navigate_back/go_forward#69

Merged
OhYee merged 2 commits intofix/browser-navigate-wait-untilfrom
copilot/sub-pr-68
Mar 12, 2026
Merged

test(browser): lock in domcontentloaded defaults for browser_navigate_back/go_forward#69
OhYee merged 2 commits intofix/browser-navigate-wait-untilfrom
copilot/sub-pr-68

Conversation

Copy link
Contributor

Copilot AI commented Mar 12, 2026

No unit tests existed to guard the wait_until="domcontentloaded" default introduced in #68 for browser_navigate_back and browser_go_forward, leaving the change vulnerable to silent regression.

Changes

  • New TestBrowserNavigationDefaults class in test_browser_toolset_error_handling.py — 4 tests asserting wait_until="domcontentloaded" and timeout=None defaults for both methods.

  • Inspection approachinspect.signature cannot introspect Tool objects produced by the @tool decorator. Tests use Tool.args_schema.model_fields instead, which is the Pydantic model the decorator builds directly from the source function's signature:

def test_browser_navigate_back_default_wait_until(self):
    fields = BrowserToolSet.browser_navigate_back.args_schema.model_fields
    assert fields["wait_until"].default == "domcontentloaded"

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

…back/go_forward

Co-authored-by: OhYee <13498329+OhYee@users.noreply.github.com>
Copilot AI changed the title [WIP] [WIP] Address feedback on default wait_until method in browser fix PR test(browser): lock in domcontentloaded defaults for browser_navigate_back/go_forward Mar 12, 2026
@OhYee OhYee marked this pull request as ready for review March 12, 2026 16:54
@OhYee OhYee merged commit d56eb1f into fix/browser-navigate-wait-until Mar 12, 2026
1 of 2 checks passed
@OhYee OhYee deleted the copilot/sub-pr-68 branch March 12, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants