Skip to content

fix(ci): resolve mypy failure and add wait_until default regression tests#70

Merged
OhYee merged 3 commits intofix/browser-navigate-wait-untilfrom
copilot/sub-pr-68-again
Mar 13, 2026
Merged

fix(ci): resolve mypy failure and add wait_until default regression tests#70
OhYee merged 3 commits intofix/browser-navigate-wait-untilfrom
copilot/sub-pr-68-again

Conversation

Copy link
Contributor

Copilot AI commented Mar 12, 2026

CI make mypy-check was failing due to a type mismatch in the integration test, and the browser_navigate_back/browser_go_forward default change lacked test coverage.

Changes

  • Fix mypy error in test_langchain_agui_integration.py: annotate input_data as Any to satisfy langgraph's Pregel.astream overloads, which expect _InputAgentState | Command[Any] | None — not the inferred dict[str, list[dict[str, str]]]

  • Add regression tests in TestBrowserNavigationDefaults to lock in wait_until="domcontentloaded" defaults for both nav functions. Uses args_schema.model_fields (Pydantic v2) since @tool wraps the underlying function and inspect.signature does not reach the original parameters:

default = BrowserToolSet.browser_navigate_back.args_schema.model_fields["wait_until"].default
assert default == "domcontentloaded"

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: OhYee <13498329+OhYee@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix default wait_until parameter from load to domcontentloaded fix(ci): resolve mypy failure and add wait_until default regression tests Mar 12, 2026
@OhYee OhYee marked this pull request as ready for review March 12, 2026 16:54
@OhYee
Copy link
Member

OhYee commented Mar 12, 2026

@copilot merge conflict

Co-authored-by: OhYee <13498329+OhYee@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 12, 2026

@copilot merge conflict

Resolved in commit 7f603bb. The base branch had merged PR #69 which already added TestBrowserNavigationDefaults (with 4 tests covering both wait_until and timeout defaults). I've updated my branch to use that version while keeping the input_data: Any annotation as the only change on top. Mypy passes with 0 errors and all 27 tests pass.

Copilot AI requested a review from OhYee March 12, 2026 17:00
@OhYee OhYee merged commit 32bb0ea into fix/browser-navigate-wait-until Mar 13, 2026
1 check passed
@OhYee OhYee deleted the copilot/sub-pr-68-again branch March 13, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants