fix(browser): change default wait_until from load to domcontentloaded by OhYee · Pull Request #68 · Serverless-Devs/agentrun-sdk-python

OhYee · 2026-03-11T04:01:37Z

Updated the default wait_until parameter from 'load' to 'domcontentloaded' for browser navigation functions to improve performance and reduce waiting time for full page loads when not necessary.

This change affects browser_navigate_back and browser_go_forward functions in the BrowserToolSet class to use 'domcontentloaded' as the default waiting strategy instead of 'load'.

将默认的 wait_until 参数从 'load' 更改为 'domcontentloaded'

更新了浏览器导航函数的默认 wait_until 参数，从 'load' 改为 'domcontentloaded' 以提高性能并减少不必要的完整页面加载等待时间。

此更改影响 BrowserToolSet 类中的 browser_navigate_back 和
browser_go_forward 函数，使用 'domcontentloaded' 作为默认等待策略而不是 'load'。

fix #66

Change-Id: Ib5d4120869bfea9ea8a411b16958bf9359572b9f

Thank you for creating a pull request to contribute to Serverless Devs agentrun-sdk-python code! Before you open the request please answer the following questions to help it be more easily integrated. Please check the boxes "[ ]" with "[x]" when done too.
Please select one of the PR types below to complete

Fix bugs

Bug detail

The specific manifestation of the bug or the associated issue.

Pull request tasks

Add test cases for the changes
Passed the CI test

Update docs

Reason for update

Why do you need to update your documentation?

Pull request tasks

Update Chinese documentation
Update English documentation

Add contributor

Contributed content

Code
Document

Content detail

if content_type == 'code' || content_type == 'document':
    please tell us `PR url`，like: https://github.com/Serverless-Devs/agentrun-sdk-python/pull/1
else:
    please describe your contribution in detail

Others

Reason for update

Why do you need to update your documentation?

Updated the default wait_until parameter from 'load' to 'domcontentloaded' for browser navigation functions to improve performance and reduce waiting time for full page loads when not necessary. This change affects browser_navigate_back and browser_go_forward functions in the BrowserToolSet class to use 'domcontentloaded' as the default waiting strategy instead of 'load'. 将默认的 wait_until 参数从 'load' 更改为 'domcontentloaded' 更新了浏览器导航函数的默认 wait_until 参数，从 'load' 改为 'domcontentloaded' 以提高性能并减少不必要的完整页面加载等待时间。此更改影响 BrowserToolSet 类中的 browser_navigate_back 和 browser_go_forward 函数，使用 'domcontentloaded' 作为默认等待策略而不是 'load'。 fix #66 Change-Id: Ib5d4120869bfea9ea8a411b16958bf9359572b9f Signed-off-by: OhYee <oyohyee@oyohyee.com>

Copilot

Pull request overview

This pull request updates BrowserToolSet’s browser history navigation defaults to wait for domcontentloaded instead of load, reducing unnecessary wait time on back/forward navigations.

Changes:

Change browser_navigate_back default wait_until from "load" to "domcontentloaded".
Change browser_go_forward default wait_until from "load" to "domcontentloaded".
Minor formatting adjustments in _get_playwright logging/conditionals.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-11T04:04:33Z

agentrun/integration/builtin/sandbox.py

+        wait_until: str = "domcontentloaded",
        timeout: Optional[float] = None,


The PR description references fixing issue #66, but the code change here only updates the default wait_until value for back/forward navigation. Please either update the PR description/issue reference to match the actual change, or include the missing code changes intended to address #66.

Copilot · 2026-03-11T04:04:33Z

agentrun/integration/builtin/sandbox.py

        self,
-        wait_until: str = "load",
+        wait_until: str = "domcontentloaded",
        timeout: Optional[float] = None,


This PR changes behavior by altering the default wait_until for browser_navigate_back/browser_go_forward, but there are no unit tests asserting the new defaults. Consider adding a small test (e.g., via inspect.signature) to lock in the new default and prevent accidental regressions.

@copilot open a new pull request to apply changes based on this feedback

Copilot · 2026-03-12T12:22:46Z

@OhYee I've opened a new pull request, #69, to work on those changes. Once the pull request is ready, I'll request review from you.

OhYee · 2026-03-12T12:23:20Z

@copilot github action run failed at make mypy-check

Copilot · 2026-03-12T12:23:28Z

@OhYee I've opened a new pull request, #70, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: OhYee <13498329+OhYee@users.noreply.github.com>

…back/go_forward Co-authored-by: OhYee <13498329+OhYee@users.noreply.github.com>

test(browser): lock in domcontentloaded defaults for browser_navigate_back/go_forward

Co-authored-by: OhYee <13498329+OhYee@users.noreply.github.com>

fix(ci): resolve mypy failure and add wait_until default regression tests

OhYee requested a review from Copilot March 11, 2026 04:01

Copilot started reviewing on behalf of OhYee March 11, 2026 04:01 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

Initial plan

1856f4e

Copilot AI mentioned this pull request Mar 12, 2026

test(browser): lock in domcontentloaded defaults for browser_navigate_back/go_forward #69

Merged

Initial plan

1c6e080

Copilot AI mentioned this pull request Mar 12, 2026

fix(ci): resolve mypy failure and add wait_until default regression tests #70

Merged

Copilot AI and others added 5 commits March 12, 2026 12:34

fix(mypy): annotate input_data as Any and add wait_until default tests

7dd8597

Co-authored-by: OhYee <13498329+OhYee@users.noreply.github.com>

test(browser): add tests locking in wait_until defaults for navigate_…

9bdfdce

…back/go_forward Co-authored-by: OhYee <13498329+OhYee@users.noreply.github.com>

Merge pull request #69 from Serverless-Devs/copilot/sub-pr-68

d56eb1f

test(browser): lock in domcontentloaded defaults for browser_navigate_back/go_forward

fix: resolve merge conflict with fix/browser-navigate-wait-until

7f603bb

Co-authored-by: OhYee <13498329+OhYee@users.noreply.github.com>

Merge pull request #70 from Serverless-Devs/copilot/sub-pr-68-again

32bb0ea

fix(ci): resolve mypy failure and add wait_until default regression tests

OhYee enabled auto-merge March 13, 2026 02:37

OhYee disabled auto-merge March 13, 2026 02:38

OhYee merged commit 7ea682c into main Mar 13, 2026
2 checks passed

OhYee deleted the fix/browser-navigate-wait-until branch March 13, 2026 02:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(browser): change default wait_until from load to domcontentloaded#68

fix(browser): change default wait_until from load to domcontentloaded#68
OhYee merged 8 commits intomainfrom
fix/browser-navigate-wait-until

OhYee commented Mar 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 11, 2026

Uh oh!

Copilot AI Mar 11, 2026

Uh oh!

OhYee Mar 12, 2026

Uh oh!

Copilot AI commented Mar 12, 2026

Uh oh!

OhYee commented Mar 12, 2026

Uh oh!

Copilot AI commented Mar 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		wait_until: str = "domcontentloaded",
		timeout: Optional[float] = None,

Conversation

OhYee commented Mar 11, 2026

Fix bugs

Update docs

Add contributor

Others

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

OhYee Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Mar 12, 2026

Uh oh!

OhYee commented Mar 12, 2026

Uh oh!

Copilot AI commented Mar 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants