Skip to content

Fix array bounds underflow #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rainyan merged 2 commits into from
Feb 22, 2026
Merged

Fix array bounds underflow #1711

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83d08db
Convert to wider type before addition
Rainyan Feb 21, 2026
d5b3659
Fix buffer underflow
Rainyan Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/game/client/neo/ui/neo_ui.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1981,6 +1981,11 @@ void SliderU8(const wchar_t *wszLeftLabel, uint8 *ucValue, const uint8 iMin, con

static int TextEditChIdxFromMouse(const int iWszTextSize)
{
if (iWszTextSize <= 0)
{
return 0;
}

const int iMouseOnXWidth = c->iMouseAbsX - (c->rWidgetArea.x0 + c->iMarginX);
int iChIdx = -1;
for (int i = 0; i < iWszTextSize; ++i)
Expand Down Expand Up @@ -2428,7 +2433,7 @@ void TextEdit(wchar_t *wszText, const int iMaxWszTextSize, const TextEditFlags f
static wchar_t wszStaticTmpText[MAX_TEXTINPUT_U8BYTES_LIMIT];
if (bFromEnd)
{
V_wcsncat(wszText, wszClipboard, iMaxWszTextSize + 1);
V_wcsncat(wszText, wszClipboard, (size_t)iMaxWszTextSize + 1);
c->iTextSelCur = V_wcslen(wszText);
}
else if (bIsCursor)
Expand Down