Skip to content

Ask about the Console during Setup - #874

Merged
JacobStephens2 merged 3 commits into
issue-776from
issue-829
Oct 20, 2026
Merged

JacobStephens2 merged 3 commits into
issue-776from
issue-829

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Summary

Setup
  Run notifications → email.to
  Console?
    yes → address + allowed emails → [console], preserving comments
          offer thirdshift console install
    no  → retain Console settings
  waiting line >= silent time → warn about the half-silence fallback

The allowlist starts with email.to; rerunning Setup keeps existing Console answers as defaults. An unset address shows thirdshift.example.com as an example.

Closes #829

Evidence

  • Before: the new Setup harness regression failed with unasked Console answers; the timing-warning regression failed because no warning appeared.
    After: 59 Setup harness tests and all 24 terminal Setup tests pass, covering saved answers/comments, both allowlist defaults, validation, declining, and cancellation.
  • Before: the Spec reviewer's exact temporary-checkout command failed with lost # owner retained when adding an allowed email.
    After: its retained regression passes, along with replace/remove coverage: cargo test --bin thirdshift setup::console_tests (9 passed). The Spec reviewer independently reran the retained regression (1 passed).
  • cargo check --all-targets, cargo clippy --all-targets -- -D warnings, cargo fmt --check, and git diff --check pass. Full cargo test: 2,052 passed, zero failed, across 55 test groups.
  • The existing Muse, OpenCode, and first-Run Setup terminal tests also pass with the new final question answered: cargo test --test muse_sessions --test opencode_sessions --test setup_offer.

Test seams

  • Setup's existing Scripted harness, through run_setup and run_offer: answers, persisted User config, terminal messages, and cancellation before writes.
  • The setup CLI on a terminal and without one, through tests/setup.rs.

Review coverage

Independent Standards and Spec reviews compared against issue-776 at 910a56b106aaf768a3269460d91f7d98616b3924, then inspected the comment-preservation fix. Standards: no findings. Spec: one reproduced finding, fixed with its regression retained.

Both axes read every changed file: src/config.rs, src/config/console.rs, src/setup.rs, src/setup/console_tests.rs, src/setup/questions.rs, tests/muse_sessions.rs, tests/opencode_sessions.rs, tests/setup.rs, and tests/setup_offer.rs. Unread changed files: none. Generated-output exclusions: none.

Unaddressed findings

  • Standards: none.
  • Spec: none.

Merge Danger

Door: two-way

Ordinary Setup config edits; no migration or automatic installation.

Blast Radius: Setup

Changes interactive Setup, its first-Run offer, and its config editing. Unsafe waiting intervals also warn during noninteractive Setup.

Built with codex · gpt-6.1-sol · high

@JacobStephens2
JacobStephens2 merged commit 78570bb into issue-776 Oct 20, 2026
19 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-829 branch October 20, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant