refactor: extract useMoneyRequestReportData - #100035
Draft
sosek108 wants to merge 6 commits into
Draft
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This is PR 6 of a 10-PR stack decomposing the MoneyRequestReport list components (
MoneyRequestReportActionsList/MoneyRequestReportTransactionList) into focused hooks and presentational sub-components (issue #99919, superseding drafts #99307 and #99417).This slice extracts the report data derivation into a dedicated hook, finishing Track A:
src/components/MoneyRequestReportView/useMoneyRequestReportData.ts— derives the view's working set from the paginated report actions and the report's transaction collection: the filtered report actions, the non-deleted transactions (including offline pending deletes), the transactions minus online pending deletions, the pending-deletion flag, and the derived ID arrays. The chain lives in its own hook so React Compiler can memoize it — inline in the component the derivations interleave with other hook calls, which puts the intermediate arrays' mutable ranges across hook boundaries and makes the whole chain ineligible for a reactive scope.src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx— final Track A wiring: replaces the inlineuseMemoderivation chain with a singleuseMoneyRequestReportDatacall, reads the track-intent flag through the sharedisTrackIntentUserSelectorOnyx selector, drops the remaininguseMemo/useCallbackwrappers (React Compiler memoizes), and replaces lodashisEmptywith.length === 0checks so the compiler keeps the arrays' mutable ranges local. After this slice the file is in its final decomposed shape.Pure refactor — no behavior change.
Stack note: this PR is stacked on #100033 (
decompose/money-request-report-transactions-a4), which is stacked on #100030, #100025, #100024 and #100023. Until those PRs merge, the diff here also shows their commits. Only the "Extract useMoneyRequestReportData" commit belongs to this slice.Fixed Issues
$ #99919
PROPOSAL:
Tests
npx jest tests/ui/MoneyRequestReportActionsListRejectModalTest.tsxand verify it passesOffline tests
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari