refactor: extract useMoneyRequestReportColumns and useMoneyRequestReportLayout - #100037
Draft
sosek108 wants to merge 8 commits into
Draft
refactor: extract useMoneyRequestReportColumns and useMoneyRequestReportLayout#100037sosek108 wants to merge 8 commits into
sosek108 wants to merge 8 commits into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This is PR 8 of a 10-PR stack decomposing the MoneyRequestReport list components (
MoneyRequestReportActionsList/MoneyRequestReportTransactionList) into focused hooks and presentational sub-components (issue #99919, superseding drafts #99307 and #99417).This slice extracts the transaction table's column derivation and the report-layout (group-by) selection into dedicated hooks:
src/components/MoneyRequestReportView/useMoneyRequestReportColumns.ts— derives which columns the transaction table shows and how wide they are: thegetColumnsToShowcall with its inputs (billable/comments/reimbursable column gates, tax enablement, saved column preferences), the wide/normal width buckets for the date/posted/amount/tax-amount columns, the table's minimum pixel width, and whether the table needs its own horizontal scroller.src/components/MoneyRequestReportView/useMoneyRequestReportLayout.ts— owns the report-layout (group-by) selection: reads the two layout NVPs, exposes the effective selection and grouping mode, latches the user's most recent pick so the popover label never flicks through the default while the NVPs settle, and persists selections viasetReportLayout.src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx— consumes the two hooks in place of the inline column/layout blocks and drops the locals/imports that moved with them (layout NVP reads, column-size memo, latch state, ReportLayout action imports).Pure refactor — no behavior change.
Stack note: this PR is stacked on #100036 (
decompose/money-request-report-transactions-b1), which is stacked on #100035, #100033, #100030, #100025, #100024 and #100023. Until those PRs merge, the diff here also shows their commits. Only the "Extract useMoneyRequestReportColumns and useMoneyRequestReportLayout" commit belongs to this slice.Fixed Issues
$ #99919
PROPOSAL:
Tests
npx jest tests/ui/MoneyRequestReportActionsListRejectModalTest.tsxand verify it passesOffline tests
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari