refactor(templates): drop the v2 suffix from the invoice package#280
Merged
Conversation
With the classic invoice stack gone, the layered presets no longer need the v2 package segment. Move templates.invoice.v2.presets to templates.invoice.presets and rewrite every import and doc reference across the engine, tests, examples, and benchmarks. Pure rename — the visual parity test passes against the unchanged committed baseline, so the render is identical. Tests: ./mvnw verify javadoc:javadoc -pl . — 1378 tests, 0 failures, javadoc clean; examples + benchmarks compile; perf-smoke + examples-generation smoke (85) green.
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
With the classic invoice stack removed, the layered presets no longer need the
v2package segment — first of the four per-family suffix drops (invoice → proposal → cover-letter → cv), smallest family first to prove the rename mechanics.What
git mv templates/invoice/v2/presets→templates/invoice/presets(main + test); rewritetemplates.invoice.v2→templates.invoiceacross all 15 referencing files (engine, tests, examples, benchmarks).{@code invoice.v2}mentions in surviving javadoc (incl. two inproposal/v2that named the now-gone package) and the invoice parent package-info.InvoiceV2VisualParityTestpasses against the unchanged committed baseline — the render is identical.Deferred:
docs/templates/v2-layered/contributor-guide.mdwalkthrough (one coherent docs pass in 3-13 after all suffixes drop); the examples' ownexamples/templates/invoice/v2/directory name (examples-internal, cosmetic).Tests
./mvnw verify javadoc:javadoc -pl .— 1378 tests, 0 failures, javadoc clean. Examples + benchmarks compile; perf-smoke + examples-generation smoke (85) green. japicmp report-only on this line.