refactor(templates): drop the v2 suffix from the proposal package#281
Merged
Conversation
Second of the four per-family suffix drops. Move templates.proposal.v2.presets to templates.proposal.presets and rewrite every import and doc reference across the engine, tests, examples, and benchmarks. Pure rename — the visual parity test passes against the unchanged committed baseline, so the render is identical. Tests: ./mvnw verify javadoc:javadoc -pl . — 1378 tests, 0 failures, javadoc clean; examples + benchmarks compile; perf-smoke + examples-generation smoke (85) green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Second of the four per-family suffix drops (invoice ✅ → proposal → cover-letter → cv), same mechanics as #280.
What
git mv templates/proposal/v2/presets→templates/proposal/presets(main + test); rewritetemplates.proposal.v2→templates.proposalacross all 9 referencing files (engine, tests, examples, benchmarks).{@code proposal.v2}mentions (data package-info, smoke test, cinematic example) and the proposal parent package-info.ProposalV2VisualParityTestpasses against the unchanged committed 2-page baseline — the render is identical.Deferred (as in #280): the
v2-layereddocs walkthrough (3-13) and the examples-ownexamples/templates/proposal/v2/dir name.Tests
./mvnw verify javadoc:javadoc -pl .— 1378 tests, 0 failures, javadoc clean. Examples + benchmarks compile; perf-smoke + examples-generation smoke (85) green. japicmp report-only on this line.