refactor(templates): drop the v2 suffix from the cover-letter package#282
Merged
Merged
Conversation
Third of the four per-family suffix drops. Move the coverletter.v2 sub-packages (data, components, presets) up to templates.coverletter and rewrite every import and doc reference across the engine, tests, and examples. The cv.v2 cross-imports (CvIdentity, CvName, SectionLookup) are untouched until the cv rename. Pure rename — the visual parity test passes against the unchanged committed baselines, so every letter preset renders identically. Tests: ./mvnw verify javadoc:javadoc -pl . — 1378 tests, 0 failures, javadoc clean; examples + benchmarks compile; perf-smoke + examples-generation smoke (85) green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Third of the four per-family suffix drops (invoice ✅ → proposal ✅ → cover-letter → cv), same mechanics as #280/#281.
What
git mvthecoverletter/v2sub-packages (data,components,presets) up totemplates/coverletter(main + test); rewritetemplates.coverletter.v2→templates.coverletteracross all 40 referencing files.{@code coverletter.v2}mentions (parent + presets package-info,ExecutiveLetterwidgets note, the gallery example).cv.v2cross-imports (CvIdentity/CvName/SectionLookup) are untouched — they rename with cv in the next PR.CoverLetterV2VisualParityTestpasses against the unchanged committed baselines — every letter preset renders identically.Deferred (as before):
docs/api-stability.md§4 tier row + thev2-layereddocs walkthrough (3-13); the examples-ownexamples/templates/coverletter/v2/dir (itsShowcaseMetadatapath still points at the real, unmoved example files).Tests
./mvnw verify javadoc:javadoc -pl .— 1378 tests, 0 failures, javadoc clean. Examples + benchmarks compile; perf-smoke + examples-generation smoke (85) green. japicmp report-only on this line.