Handle failed LQR local paths in LQR-RRT* steering - #1421
Open
huxiaoyi-ovo wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NonefromLQRRRTStar.steer()instead of indexing an empty listProblem
LQRPlanner.lqr_planning()explicitly returns([], [])when it cannot find a path.LQRRRTStar.steer()currently checks onlyif px is None, so an empty list passes the check and the subsequentpx[-1]/py[-1]access raisesIndexError.Fix
Treat an empty sampled path as a failed steering attempt with
if not px: return None. This matches the existing planner convention thatNoneindicates steering failure and lets the RRT* search continue safely.Tests
Added
test_steer_handles_failed_local_planner. The test uses the realLQRPlannerwithMAX_TIME = 0.0, which deterministically exercises its existing no-path return([], []), and verifies thatsteer()returnsNonewithout raising.