Handle goal node at index zero in RRT Dubins - #1420
Open
huxiaoyi-ovo wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0as a valid search result inRRTDubinsProblem
search_best_goal_node()returns a node index orNone. The planner currently checks the result withif last_index:, so a valid result of0is treated as false and the planner incorrectly reports that no path was found.This occurs naturally when the start node itself already satisfies the goal position and yaw thresholds.
Fix
Use an explicit
is not Nonecheck for the returned node index.Tests
Added
test_start_already_satisfies_goalwithmax_iter=0, which makes node index0the valid goal result and verifies that planning returns a path.