Fix Dijkstra failure when goal is unreachable - #1418
Open
huxiaoyi-ovo wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValueErrorProblem
When the goal is unreachable, Dijkstra eventually exhausts
open_set. The next call tomin(open_set, ...)then raisesValueError: min() arg is an empty sequence.Other grid-search implementations in this repository already guard against an empty open set. This change adds equivalent handling to Dijkstra and returns
([], [])to make the no-path result explicit.Tests
Added
test_unreachable_goalintests/test_dijkstra.pyto verify that an unreachable goal returns empty path lists without throwing an exception.