feat: ingest new manual water software events - #102
Merged
arjunsridhar12345 merged 7 commits intoSep 15, 2026
Merged
arjunsridhar12345 merged 7 commits into
arjunsridhar12345 merged 7 commits into
Conversation
alexpiet
reviewed
Sep 15, 2026
| | `auto` | Free water: the matched trial has `is_auto_reward_right` set. Scheduled autowater and the anti-bias intervention share that channel and are **not** split here — `auto_waterL` / `auto_waterR` and `anti_bias_left_water` / `anti_bias_right_water` record the mechanism per trial. | | ||
| | `manual` | The delivery is the closest valve opening to a `GiveManualWater` software event for this port. Takes precedence over the other labels, since manual water is not aligned to a go cue. | | ||
| | `manual_go_cue_aligned` | The delivery is the closest valve opening to a `LeftManualAutoReward` / `RightManualAutoReward` software event for this port: water the *experimenter* triggered to land on the go cue. It fires at the go cue like autowater, but the task did not schedule it, so it is neither `auto` nor `earned`. Takes precedence over both trial-derived labels. | | ||
| | `manual` | The delivery is the closest valve opening to a `LeftManualWater` / `RightManualWater` software event for this port: experimenter water given at an arbitrary moment, tied to no go cue. Highest precedence of all four. | |
There was a problem hiding this comment.
I would change "tied to no go cue" to "not tied to a go cue"
alexpiet
approved these changes
Sep 15, 2026
arjunsridhar12345
deleted the
101-refactor-to-ingest-new-manual-water-software-events
branch
September 15, 2026 23:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to close #101. Label annotations going into acquisition table of NWB are now
manualandmanual_go_cue_aligned. these can be easily changed. Tested on a sample session Micah ran (don't think this is real data)Sample qc plot: