stm32: configure power supply through Device Tree #99171
Conversation
zephyrbot
added
Release Notes
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
HoZHel,
asm5878,
ceolin,
cfriedt,
djiatsaf-st,
erwango,
etienne-lms,
facchinm,
gautierg-st,
jhedberg,
juickar,
kartben and
pillo79
|
As CI build notes, there are a few board DTS files that need to be updated with |
mathieuchopstm
force-pushed
the
stm32_pwr_via_dt
branch
from
6fa6b34 to
4bd4a57
Compare
zephyrbot
requested review from
bjarki-andreasen,
fabiobaltieri and
keith-zephyr
mathieuchopstm
force-pushed
the
stm32_pwr_via_dt
branch
from
4bd4a57 to
3f78690
Compare
|
@mathieuchopstm there's a merge conflict - please rebase |
mathieuchopstm
dismissed stale reviews from asm5878, erwango, and etienne-lms
via
6d358d0
mathieuchopstm
force-pushed
the
stm32_pwr_via_dt
branch
from
118853d to
6d358d0
Compare
|
Rebased + added a |
mathieuchopstm
requested review from
asm5878,
erwango and
etienne-lms
and removed request for
erwango
Fix some formatting issues in the board's DTS which trigger CI failures. Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
Introduce a new binding for the power controller of STM32H7 series. Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
Add node representing the Power Controller to SoC DTSI of STM32H7 series, and update DTS of all STM32H7-based boards since the new node has required properties. Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
Replace the existing infrastructure to specify power supply configuration through Kconfig with Devicetree. Also update all boards that were defining the Kconfig to no longer do so. Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
Introduce a new binding for the Power Controller of the STM32H7R/S series. Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
Add node representing the Power Controller to SoC DTSI of STM32H7RS series, and update DTS of all STM32H7RS-based boards since the new node has required properties. Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
Replace the existing infrastructure to specify power supply configuration through Kconfig with Devicetree. Also update all boards that were defining the Kconfig to no longer do so. Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
Introduce power controller binding for series equipped with two voltage regulators (LDO + SMPS). Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
Replace the existing infrastructure to specify power supply configuration through Kconfig with Devicetree. Set the LDO as default to reduce out-of-tree breakage - most users were relying on LDO being the default and it is harmless to use LDO if board is designed for SMPS. (Existing SMPS users should break anyways since the Kconfig symbol no longer exists, but this ensures they actively set the power supply to SMPS in DT) Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
Replace the existing infrastructure to specify power supply configuration through Kconfig with Devicetree, and update all boards according to new mechanism. Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
Add an entry about the STM32 power supply configuration to the migration guide for release 4.4 - it is now done through Devicetree instead of Kconfig, and all existing Kconfig symbols have been deleted. Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
mathieuchopstm
force-pushed
the
stm32_pwr_via_dt
branch
from
6d358d0 to
0976a81
Compare
|
etienne-lms
left a comment
etienne-lms
left a comment
There was a problem hiding this comment.
Non-blocking comments.
|
|
||
| * ``CONFIG_POWER_SUPPLY_LDO`` | ||
|
|
||
| * ``CONFIG_POWER_SUPPLY_DIRECT_SMPS``, |
There was a problem hiding this comment.
Nitpicking; comma here and at line 57 but not for the other configs?
Also, I think you could drop the empty lines between lines 51 and 67.
I wondered if this enumeration should use :kconfig:option: prefix. But maybe not applicable since the config symbols have been removed.
There was a problem hiding this comment.
Comma is a good catch - stray remains from rework...
Indeed, :kconfig:option: can't be used here since the options no longer exist.
9 participants
Replace the existing Kconfig-based mechanism to select the power supply with a Devicetree-based approach, inspired by the STM32WB0 implementation.
Commits could be reorganized: currently, they're split by series, but also squash SoC DTSI and board DTS changes together - I could mark properties as not required initially then perform updates separately, and make required in a last-pass commit if that sounds cleaner.