drivers: video: stm32-dcmi: correct set_frmival handling #99154
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct set_frmival in order to avoid having un-optimized frmival selection due to rounded values. Computation has been done in usec, leading to incorrect frmival selection due to value being rounded internally. As an example, code was selecting 1/60 from sensor then 4 time frame drop by DCMI instead of selecting directly 1/15 from sensor. Use msec instead to hide those rounding issue and avoid as well 64bit variables. This also put the first video_frmival_nsec outside of the loop to avoid having to do the processing everytime. Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Author
|
This PR tackles point discussed in PR #98154, cf #98154 (comment) |
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
josuah,
juickar,
loicpoulain,
mathieuchopstm and
ngphibang
|
Contributor
|
Appears to the issue I was having with the HM01b0 camera |
Contributor
|
Will add to @KurtE's comment. Tested with the HM0360 as well and again seems to have fixed the issue we were seeing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct set_frmival in order to avoid having un-optimized frmival selection due to rounded values.
Computation has been done in usec, leading to incorrect frmival selection due to value being rounded internally. As an example, code was selecting 1/60 from sensor then 4 time frame drop by DCMI instead of selecting directly 1/15 from sensor.
Use msec instead to hide those rounding issue and avoid as well 64bit variables.
This also put the first video_frmival_nsec outside of the loop to avoid having to do the processing everytime.