Skip to content

drivers: video: stm32-dcmi: correct set_frmival handling #99154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −4
Open

drivers: video: stm32-dcmi: correct set_frmival handling #99154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions drivers/video/video_stm32_dcmi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,10 +375,12 @@ static int video_stm32_dcmi_set_frmival(const struct device *dev, struct video_f
.format = &data->fmt,
};
struct video_frmival best_sensor_frmival;
uint64_t best_diff_nsec = INT32_MAX;
uint64_t diff_nsec = 0, a, b;
uint32_t best_diff_nsec = INT32_MAX;
uint32_t diff_nsec = 0, a, b;
int best_capture_rate = 1;

a = video_frmival_nsec(frmival) / USEC_PER_MSEC;

/*
* Try to figure out a frameinterval setting allow to reach as close as
* possible to the request. At first without relying on DCMI frame control,
Expand All @@ -392,9 +394,8 @@ static int video_stm32_dcmi_set_frmival(const struct device *dev, struct video_f
fie.discrete.numerator = frmival->numerator;
fie.discrete.denominator = frmival->denominator * capture_rate;

a = video_frmival_nsec(&fie.discrete);
video_closest_frmival(config->sensor_dev, &fie);
b = video_frmival_nsec(&fie.discrete);
b = video_frmival_nsec(&fie.discrete) * capture_rate / USEC_PER_MSEC;
diff_nsec = a > b ? a - b : b - a;
if (diff_nsec < best_diff_nsec) {
best_diff_nsec = diff_nsec;
Expand Down