Skip to content

ci: lint workflows and pin third-party actions to SHAs - #988

Merged
Teakowa merged 1 commit into
mainfrom
wright-actionlint
Oct 25, 2026
Merged

Teakowa merged 1 commit into
mainfrom
wright-actionlint

Conversation

@e54-bot

@e54-bot e54-bot commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

Refs wrightkit/.github#124

What changed

  • ci.yml: new workflow-lint job calling wrightkit/.github/.github/workflows/actionlint.yml@main, wired into ci-result.needs.
  • ci-jobs.py: any unconditional job is now a required job (previously only paths qualified; other unconditional jobs errored). test-ci-jobs.py asserts workflow-lint required.
  • All tag-pinned third-party actions in ci.yml, release.yml, release-please.yml migrated to full commit SHAs with resolved tags as comments (checkout, paths-filter, upload/download-artifact, setup-python, setup-node, release-please-action).

Verification

  • Every pinned SHA resolved against the live tag ref before commit.
  • actionlint v1.7.12 clean on all three workflows; scripts/ci-jobs.py check and scripts/test-ci-jobs.py (8/8) pass.

Sibling of wrightkit/.github#129 (merged — provides the reusable actionlint workflow). Part of the cross-repository issue; this PR alone does not close it.

Call the shared actionlint workflow from ci.yml and wire it into
ci-result.needs so workflow changes are linted in CI. Generalize
ci-jobs.py so every unconditional job is required (previously only
`paths` was recognized; any other unconditional job failed the check).

Migrate every tag-pinned third-party action in the repository's
workflows to a full commit SHA with the resolved tag as a comment, per
the ci-platform mandate now covering actions/* explicitly.

Refs wrightkit/.github#124
@Teakowa
Teakowa merged commit 1f009c8 into main Oct 25, 2026
37 checks passed
@Teakowa
Teakowa deleted the wright-actionlint branch October 25, 2026 06:19
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Make Workshop Great Again Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants