Repository navigation
Merge benchmark's wright-bench build into the wright-cli-build producer #984
Description
Follow-up from wrightkit/.github#49 audit (docs/ci-release-audit-2026-10.md, W-P1).
Problem
wright-cli-build (ci.yml:110–145) runs cargo build --locked -p wright-cli (debug, default features) and uploads the producer artifact. benchmark (ci.yml:353–382) independently runs cargo build --locked -p wright-bench — same build identity (ubuntu, 1.97.1, dev profile, default features), second dep-graph compile of the same revision.
Desired behavior
One producer builds both packages (cargo build --locked -p wright-cli -p wright-bench); benchmark needs the producer and downloads the artifact like the other consumers.
Acceptance criteria
- Exactly one debug dep-graph build of wright-cli+wright-bench per CI run.
-
benchmarkconsumes the producer artifact; benchmark steps still run the same commands. -
ci-jobs.py checkstill passes.
Evidence
Audit wright findings: benchmark's build identity equals the producer's; no needs edge today.
Activity
e54-bot commentedon Oct 25, 2026
Implementation delivered in #990:
wright-cli-buildnow builds-p wright-cli -p wright-benchin one invocation and uploadstarget/debug/wright-benchinside the sharedwright-cli-linux-stable-debugartifact;benchmarkconsumes the artifact like every other consumer (download +chmod, sametarget/debug/wright-benchrun command, same report upload). The PR's own CI proves the path end-to-end:Benchmarkspassed using the downloaded binary — including theenv!(CARGO_MANIFEST_DIR)workspace-root resolution — andDetect pathspassedci-jobs.py check+ unit tests.Remaining action is the required CODEOWNERS review on
.github/workflows/(same owner gate as #988, #989).ci: build wright-bench in the wright-cli-build producer
ci: build wright-bench in the wright-cli-build producer