Skip to content

ci: enforce release-job timeouts and add workflow lint - #129

Merged
e54-bot merged 2 commits into
mainfrom
gh-124-ci-conformance
Oct 24, 2026
Merged

e54-bot merged 2 commits into
mainfrom
gh-124-ci-conformance

Conversation

@e54-bot

@e54-bot e54-bot commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

Refs #124

What changed

  • release-plz-crates.yml: timeout-minutes: 30 on the release and release-pr jobs (rust-ci rule 7).
  • New reusable actionlint.yml (workflow_call + self-check on workflow changes to main); caller repositories consume it via uses: wrightkit/.github/.github/workflows/actionlint.yml@main.
  • ci-platform.md: actions/* explicitly counts as third-party under the full-SHA pin mandate.
  • Fixed two pre-existing actionlint errors in release-plz-crates.yml that the new self-check surfaces: the invalid concurrency.queue key (job-level concurrency accepts only group/cancel-in-progress; cancel-in-progress: false already serializes) and the undeclared CARGO_REGISTRY_TOKEN secret (declared optional so the release-environment fallback resolves under workflow_call).

Ordering

This PR merges first: sibling PRs in wright, workshop-rs, opy-rs, and athena call actionlint.yml@main and their workflow-lint jobs cannot resolve until this lands.

Verification

  • actionlint v1.7.12 clean on all three workflows in this repository (run locally).
  • Both added secrets/keys verified against the workflow_call schema.

Part of wrightkit/.github#124 together with the caller PRs; this PR alone does not close the issue.

Add timeout-minutes to the release-plz-crates release and release-pr
jobs per the rust-ci rule, and add an actionlint workflow usable both as
this repository's self-check and as a reusable workflow for callers.

The self-check surfaced two pre-existing errors in release-plz-crates.yml:
remove the invalid `concurrency.queue` key (job-level concurrency only
accepts group and cancel-in-progress; `cancel-in-progress: false`
already serializes the runs) and declare `CARGO_REGISTRY_TOKEN` so the
release-environment fallback resolves under workflow_call.

State in ci-platform.md that GitHub-owned actions/* also fall under the
third-party full-SHA pin mandate, since their tags move the same way.

Refs #124
@e54-bot
e54-bot requested a review from Teakowa as a code owner October 24, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants