Skip to content

Adds new Sparkle options #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 3, 2025
+16 −2
Merged

Adds new Sparkle options #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bd0761
Adds new Sparkle options
Usiel Nov 5, 2025
93a79c4
Increase max class length
Usiel Nov 5, 2025
dfba636
Update CHANGELOG.md with Sparkle param feature
Usiel Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ Metrics/BlockLength:
- spec/**/shared_examples_*.rb

Metrics/ClassLength:
Max: 300
Max: 350
Copy link
Contributor Author

@Usiel Usiel Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UploadBuildToAppsCdnAction has not taken any additional responsibilities. We just happen to finally reach this limit due to the two new params and their descriptions.

I didn't see anything we would absolutely want to remove from that class just to shut up rubocop, but maybe someone else sees anything they wanted to extract anyway?


Metrics/MethodLength:
Max: 150
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ _None_

### New Features

_None_
- `upload_build_to_apps_cdn`: Add additional Sparkle meta fields `critical_update` and `phased_rollout_interval` [#673]

### Bug Fixes

Expand Down
14 changes: 14 additions & 0 deletions lib/fastlane/plugin/wpmreleasetoolkit/actions/common/upload_build_to_apps_cdn.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ def self.run(params)
version: params[:version],
build_number: params[:build_number], # Optional: may be nil
minimum_system_version: params[:minimum_system_version], # Optional: may be nil
critical_update: params[:critical_update], # Optional: may be nil
phased_rollout_interval: params[:phased_rollout_interval], # Optional: may be nil
post_status: params[:post_status], # Optional: may be nil
release_notes: params[:release_notes], # Optional: may be nil
sha: params[:sha], # Optional: may be nil
Expand Down Expand Up @@ -292,6 +294,18 @@ def self.available_options
optional: true,
type: String
),
FastlaneCore::ConfigItem.new(
key: :critical_update,
description: 'Whether the build is a critical update',
optional: true,
type: Boolean
),
FastlaneCore::ConfigItem.new(
key: :phased_rollout_interval,
description: 'The interval for the phased rollout (in seconds)',
optional: true,
type: Integer
),
FastlaneCore::ConfigItem.new(
key: :release_notes,
description: 'The release notes to show with the build on the blog frontend',
Expand Down