Adds new Sparkle options #673
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usiel
commented
Nov 5, 2025
|
|
||
| Metrics/ClassLength: | ||
| Max: 300 | ||
| Max: 350 |
Author
There was a problem hiding this comment.
UploadBuildToAppsCdnAction has not taken any additional responsibilities. We just happen to finally reach this limit due to the two new params and their descriptions.
I didn't see anything we would absolutely want to remove from that class just to shut up rubocop, but maybe someone else sees anything they wanted to extract anyway?
Usiel
force-pushed
the
usielriedl/add-more-sparkle-options
branch
2 times, most recently
from
47627f5 to
64112bb
Compare
Usiel
force-pushed
the
usielriedl/add-more-sparkle-options
branch
from
64112bb to
dfba636
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Makes 2 new Sparkle meta fields available via the wpmreleasetoolkit. See https://sparkle-project.org/documentation/publishing/#publishing-an-update and https://github.a8c.com/Automattic/wpcom/pull/195377.
https://linear.app/a8c/issue/PROXY-66
Checklist before requesting a review
bundle exec rubocopto test for code style violations and recommendations.Add Unit Tests (akaspecs/*_spec.rb) if applicable.bundle exec rspecto run the whole test suite and ensure all your tests pass.CHANGELOG.mdfile to describe your changes under the appropriate existing###subsection of the existing## Trunksection.If applicable, add an entry in theMIGRATION.mdfile to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.