Skip to content

Fix: removed unneccesary memset from clu_sign.c #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aidankeefe2022 wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −2
Open

Fix: removed unneccesary memset from clu_sign.c #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/sign-verify/clu_sign.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,7 +929,6 @@ int wolfCLU_sign_data_xmss(byte* data, char* out, int fSz, char* privKey)
#endif

/* init the XMSS key */
XMEMSET(key, 0, sizeof(XmssKey));

@dgarske dgarske Aug 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: There are other places in wolfCLU specifically with wc_XmssKey_Init that use this. The PR should cover them all, right?

ret = wc_XmssKey_Init(key, HEAP_HINT, 0);
if (ret != 0) {
wolfCLU_LogError("Failed to initialize XMSS Key."
Expand Down Expand Up @@ -1109,7 +1108,6 @@ int wolfCLU_sign_data_xmssmt(byte* data, char* out, int fSz, char* privKey)
#endif

/* init the xmss key */
XMEMSET(key, 0, sizeof(XmssKey));
ret = wc_XmssKey_Init(key, HEAP_HINT, 0);
if (ret != 0) {
wolfCLU_LogError("Failed to initialize XMSS Key.\nRET: %d", ret);
Expand Down
Loading