Fix: removed unneccesary memset from clu_sign.c - #279
Open
aidankeefe2022 wants to merge 1 commit into
Open
Conversation
aidankeefe2022
changed the title
dgarske
self-requested a review
August 6, 2026 22:43
dgarske
approved these changes
Aug 7, 2026
dgarske
requested changes
Aug 7, 2026
| #endif | ||
|
|
||
| /* init the XMSS key */ | ||
| XMEMSET(key, 0, sizeof(XmssKey)); |
Member
There was a problem hiding this comment.
Note: There are other places in wolfCLU specifically with wc_XmssKey_Init that use this. The PR should cover them all, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wc_XmssKey_Init(...) sets the input key to zero at the top of the function