You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: retain contact capture while virtual lists recycle - #59
Virtual list recycling and momentum can retire an unacquired contact capture just before a native action opens a Web overlay. Retain pending acquisition across visual invalidations while retiring completed pixels and obsolete source revisions.
Connect Android Core and SDK registrations to one contact-acquisition path. Hosted SDK contact stops source motion, measures current bounds, and acquires immutable pixels before original SDK input. Reuse existing Window replay only when acquisition is needed; ready pixels keep synchronous input delivery. Preserve native taps/long presses on timeout or failure, retire token-associated requests on release, and retain acquisition-time anchors while PNG processing finishes.
In the shared SDK session, defer fallback hiding only while the selected contact capture is being processed or decoded. Failure resumes fallback and explicit none hides immediately. Native visibility/restoration semantics remain unchanged. Android advertises that capture can be armed during Web input; iOS keeps its existing capability policy.
Validation: 150 browser tests pass; all four pinned-contact fallback regressions also pass, including a new iOS-capability-style hung-response timeout and late-token release case; Android contact/input/SDK tests 16/16 and existing scroll hosting 9/9 pass. Full native suite is 54/55 locally; its fractional placement assertion also fails on the unchanged baseline. Android API35 integrated Scroll/Virtual/combined tests pass 9/9 with same-token native entry-copy drawing and subsequent visible Web images. iOS26.5 passes12/12; iOS27.2 combined6/6 and Virtual3/3 pass, with Scroll3/3 on isolated rerun after a failed concurrent run. Local supervisor/independent reviews were repeated until implementation findings were resolved.
Limit: optional capture still falls back on the existing composited-copy/Web-draw deadline under load. A concurrent stress run hit that deadline; four isolated composited SDK runs completed cover-to-painted in118–157ms. Tests use simulators/emulators and real native controls, not physical devices or the AdMob SDK itself.
The complementary plugin acknowledgement/Core wiring is tracked in webview-native-ui/capacitor-plugin#56. Its Android API adoption waits for this Engine API to be released and plugin dependency pins updated. Release-only generated runtime artifacts remain excluded from main and are generated by the existing release workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Virtual list recycling and momentum can retire an unacquired contact capture just before a native action opens a Web overlay. Retain pending acquisition across visual invalidations while retiring completed pixels and obsolete source revisions.
Connect Android Core and SDK registrations to one contact-acquisition path. Hosted SDK contact stops source motion, measures current bounds, and acquires immutable pixels before original SDK input. Reuse existing Window replay only when acquisition is needed; ready pixels keep synchronous input delivery. Preserve native taps/long presses on timeout or failure, retire token-associated requests on release, and retain acquisition-time anchors while PNG processing finishes.
In the shared SDK session, defer fallback hiding only while the selected contact capture is being processed or decoded. Failure resumes fallback and explicit none hides immediately. Native visibility/restoration semantics remain unchanged. Android advertises that capture can be armed during Web input; iOS keeps its existing capability policy.
Validation: 150 browser tests pass; all four pinned-contact fallback regressions also pass, including a new iOS-capability-style hung-response timeout and late-token release case; Android contact/input/SDK tests 16/16 and existing scroll hosting 9/9 pass. Full native suite is 54/55 locally; its fractional placement assertion also fails on the unchanged baseline. Android API35 integrated Scroll/Virtual/combined tests pass 9/9 with same-token native entry-copy drawing and subsequent visible Web images. iOS26.5 passes12/12; iOS27.2 combined6/6 and Virtual3/3 pass, with Scroll3/3 on isolated rerun after a failed concurrent run. Local supervisor/independent reviews were repeated until implementation findings were resolved.
Limit: optional capture still falls back on the existing composited-copy/Web-draw deadline under load. A concurrent stress run hit that deadline; four isolated composited SDK runs completed cover-to-painted in118–157ms. Tests use simulators/emulators and real native controls, not physical devices or the AdMob SDK itself.
The complementary plugin acknowledgement/Core wiring is tracked in webview-native-ui/capacitor-plugin#56. Its Android API adoption waits for this Engine API to be released and plugin dependency pins updated. Release-only generated runtime artifacts remain excluded from main and are generated by the existing release workflow.