Repository navigation
Conversation
Contributor
レビューCI はすべて green です。変更は最小限で、原因(virtual list の recycle で 確認した点は次のとおりです。
気になる点(軽微):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a tab switch clears cached pixels, virtual list recycling can keep the update queue dirty during momentum scrolling. Native controls have already acknowledged a new revision, but capture preparation waits for an idle queue and can remain on the previous revision.
Pass acknowledged sources to capture preparation immediately after ownership transfer, preserving the navigation/vertical-gesture guards. Keep the existing settled refresh as a fallback. Crossfade completion/cancellation explicitly invalidates prepared pixels so a frame captured during the acquisition fade cannot remain cached for a later overlay. Add a regression that holds the next update pending and verifies the acknowledged revision is already available to capture preparation.
Validation: regression fails before the change; all 421 Core tests and all 43 adapter tests pass after it. A deferred Animation.finished regression also fails before the fade-completion invalidation fix.
Device limitation: repeated tab-switch + momentum-scroll behavior still needs end-to-end device confirmation. The regression verifies capture scheduling rather than UIKit screenshot pixels. This is complementary to the Engine visual-invalidation fix: webview-native-ui/engine#59.