Skip to content

fix(a11y): fixed background contrast in Lighthouse #8103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pranjalisr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(a11y): fixed background contrast in Lighthouse #8103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Footer/Footer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const footerLinkClasses =

const Footer = () => (
<footer className="w-full flex-[0_0_auto] print:hidden">
<Container className="mx-auto max-w-[900px] px-5 pb-[30px] pt-[40px] text-center [&_a]:text-[#3b7eb5]">
<Container className="mx-auto max-w-[900px] px-5 pb-[30px] pt-[40px] text-center [&_a]:text-[#1f5fbf] dark:[&_a]:text-[#58a6ff]">
<div className="mb-[24px] flex justify-center">
<a href="https://openjsf.org" target="_blank" rel="noopener noreferrer">
<img
Expand Down
26 changes: 26 additions & 0 deletions src/components/Markdown/Markdown.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,32 @@ $topHeightMobileWithBanner: $bannerHeight + $topHeightMobile;
text-underline-offset: 2px;
text-decoration-thickness: 1px;
}
p a,
li a {
color: #1f5fbf;
font-weight: 600;
}

p a:hover,
li a:hover {
color: #174ea6;
}

.dark p a,
.dark li a {
color: #58a6ff;
}

.dark p a:hover,
.dark li a:hover {
color: #79c0ff;
}

p a:focus-visible,
li a:focus-visible {
outline: 2px solid currentColor;
outline-offset: 2px;
}
pre {
background-color: #2d3748;
color: #e2e8f0;
Expand Down
2 changes: 1 addition & 1 deletion src/components/Navigation/Navigation.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ function Navigation({ links, pathname, hash = "", toggleSidebar }) {
>
{link.children.map((child) => {
const classNames =
"text-blue-400 dark:text-[#69a8ee] py-5 text-sm capitalize hover:text-black dark:hover:text-white";
"text-blue-800 dark:text-blue-300 py-5 text-sm capitalize hover:text-blue800 dark:hover:text-blue-300";
const isActive = location.pathname.startsWith(child.url);
return (
<NavLink
Expand Down
Loading